Deb and Rpm file launcher executes "Exec=/usr/share/code/code --unity-launch %F" , Unity launcher no longer used by Ubuntu

[ghost]

Does this issue occur when all extensions are disabled?: Yes

Deb and Rpm file launcher executes "Exec=/usr/share/code/code --unity-launch %F"

The launcher for the deb and rpm installs runs "Exec=/usr/share/code/code --unity-launch %F" , I assume this has something to do with the fact old versions of Ubuntu used the "Unity" launcher , the unity launcher is now retired I assume this flag no longer does what it is intended.

• VS Code Version: 1.64.2 (all from what I have tested)
• OS Version: Ubuntu 20.04 (also all from what I have tested)

Steps to Reproduce:

1. Download any deb or rpm package
2. Look at laucher (code.desktop)

[Tyriar]

I think this was for supporting shift+click on the unity dock to open a new window, we may be able to switch this to use --new-window but it would need testing. Also yes it's a bit weird that it says unity now but it doesn't do any harm.

[ghost]

I think this was for supporting shift+click on the unity dock to open a new window, we may be able to switch this to use --new-window but it would need testing. Also yes it's a bit weird that it says unity now but it doesn't do any harm.

That would be cool , it would be reassuring to know it's not a mistake and the launcher is working as intended. I can build tests from source if wanted.

[deepak1556]

Steps for verification when changing args, #21133 (comment)

[rzhao271]

Merging into #212125