Lockup on load due to Workspace Trust

[Jason3S]

Issue Type: Bug

VS Code Insiders gets stuck showing the Workspace Trust messsage.

See Image:

This seems to be the interaction between two Extensions.

• Extension A needs Extension B
• Extension A does NOT have the trust settings configured
• Extension B does have the trust settings configured to not run in
  an untrusted environment.

Note: In my case, the workspace is trusted or at least should be.

It seem like Extension A is getting loaded and requesting Extension B, but the trust settings do not seem to be loaded yet, causing things to get stuck.

If I disable Extension A, then it is possible to load the Insiders eddition.

Example Extesions:

1. Extension A - Russian - Code Spell Checker - Visual Studio Marketplace
2. Extension B - Code Spell Checker - Visual Studio Marketplace
   Note: Version 2+ is needed. That can be found here: Release Release v2.0.1-alpha.2 · streetsidesoftware/vscode-spell-checker

Note: The file explorer is stuck and will not load.
It is not possible to open any files or workspaces.

It was possible to disable the Russian extension and restart VS Code. At that point, things started to work.

Re-enabling the Russian extension does not seem to be an issue.

Note: All of this happened after Updating Insiders.

VS Code version: Code - Insiders 1.57.0-insider (b4c1bd0, 2021-06-09T10:41:06.148Z)
OS version: Darwin x64 20.5.0
Restricted Mode: No

System Info

Item	Value
CPUs	Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 x 2600)
GPU Status	2d_canvas: enabled gpu_compositing: enabled metal: disabled_off multiple_raster_threads: enabled_on oop_rasterization: enabled opengl: enabled_on rasterization: enabled skia_renderer: disabled_off_ok video_decode: enabled webgl: enabled webgl2: enabled
Load (avg)	3, 4, 4
Memory (System)	16.00GB (0.04GB free)
Process Argv	--crash-reporter-id 8a187fff-41be-45e7-828b-45e2d22eebd7
Screen Reader	no
VM	0%

Extensions (6)

Extension	Author (truncated)	Version
vscode-eslint	dba	2.1.22
prettier-vscode	esb	6.4.0
language-haskell	jus	3.4.0
vscode-typescript-tslint-plugin	ms-	1.3.3
debugger-for-chrome	msj	4.12.12
code-spell-checker	str	2.0.0

A/B Experiments

vsliv695:30137379
vsins829:30139715
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
pythonvspyt602:30291494
vspor879:30202332
vspor708:30202333
vspor363:30204092
pythonvspyt639:30291487
pythontb:30258533
vsc_aa:30263845
pythonvspyt551cf:30291413
vspre833:30267464
pythonptprofiler:30281269
vshan820:30294714
pythondataviewer:30285072
vscus158cf:30286554
pythonvsuse255:30303025
vscgsv2:30305091
vscorehov:30301224
3f5j7703:30294757
vscod805:30301674
vscextlang:30310088
vsccppwt:30312692

[vscodebot]

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

• Trust workspace dialog does not go away after the trusted folders setting is updated (#122450)

[sbatten]

@Jason3S I have tested with the extension links you provided but am not able to reproduce this issue. Is this something that you can reproduce reliably?

[Jason3S]

@sbatten,

Thank you for trying it out. I was not able to reproduce it either.

It happened when I restarted VS Code Insiders. I think the order of the extensions matters. Because I had gotten a message that said something like "Russian extension is dependent upon another extension that cannot run because the workspace is untrusted".

Might as well close this. If it happens again or to someone else, then it can be re-opened.

Note: accessing files is very slow with the Insiders edition. The explorer can take minutes to update. Might be related to #124723 only I do not work remotely. When this happens type checking also stops working.

[sbatten]

Thanks for getting back about this, one additional question: Were you always on the last Insiders from the time you saw the issue? Or were you potentially a few days behind on the initial repro?

[Jason3S]

I was a few days behind. From mid-last week to today.

[Jason3S]

Even so. I was not able to get the latest version of the Insiders to work until I disabled the Russian extension. After restarting, things worked. Re-enabling the extension didn't seem to be an issue.

[Jason3S]

I have not seen it again. I'll open a new issue if it happens again.