Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs in YAML comment cause syntax highlighting to not work #117407

Closed
rcjsuen opened this issue Feb 23, 2021 · 1 comment
Closed

Tabs in YAML comment cause syntax highlighting to not work #117407

rcjsuen opened this issue Feb 23, 2021 · 1 comment
Assignees
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream

Comments

@rcjsuen
Copy link
Contributor

rcjsuen commented Feb 23, 2021

Issue Type: Bug

Tabs prevent comments from being highlighted correctly in YAML.

redis:
  # good comment
  enabled: true
  # 	bad comment
  image:
    pullPolicy: IfNotPresent

image

VS Code version: Code 1.53.2 (622cb03, 2021-02-11T11:45:54.515Z)
OS version: Darwin x64 19.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i9-9980HK CPU @ 2.40GHz (16 x 2400)
GPU Status 2d_canvas: enabled
gpu_compositing: enabled
metal: disabled_off
multiple_raster_threads: enabled_on
oop_rasterization: enabled
opengl: enabled_on
protected_video_decode: unavailable_off
rasterization: enabled
skia_renderer: disabled_off_ok
video_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 5, 6, 6
Memory (System) 32.00GB (2.57GB free)
Process Argv . --crash-reporter-id 87f5170f-46d6-4287-a618-c0e8a137aff7
Screen Reader no
VM 0%
Extensions (3)
Extension Author (truncated) Version
gitlens eam 11.2.1
go gol 0.22.1
vscode-docker ms- 1.10.0
A/B Experiments
vsliv368:30146709
vsreu685:30147344
python383cf:30185419
vspor879:30202332
vspor708:30202333
vspor363:30204092
vswsl492:30256859
vstry914:30256638
pythonvsdeb440:30248342
pythonvsded773:30248341
pythonvspyt875:30259475
pythontb:30260843

@alexr00
Copy link
Member

alexr00 commented Feb 26, 2021

Since we get our yaml syntax highlighting grammar from another repo, I have opened an issue there: textmate/yaml.tmbundle#36

@alexr00 alexr00 closed this as completed Feb 26, 2021
@alexr00 alexr00 added grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream labels Feb 26, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
grammar Syntax highlighting grammar upstream-issue-linked This is an upstream issue that has been reported upstream
Projects
None yet
Development

No branches or pull requests

3 participants