fix: only register inputModel when we create it

roblourens · Copilot · roblourens · commit 5e7cc23f4327 · 2026-04-12T18:28:18.000-07:00
Only dispose the input model when ChatInputPart created it. If someone
else created the model (getModel returns an existing one), we should
not take ownership of its lifecycle.

Co-authored-by: Copilot &lt;223556219+Copilot@users.noreply.github.com&gt;
diff --git a/src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts b/src/vs/workbench/contrib/chat/browser/widget/input/chatInputPart.ts
@@ -2421,8 +2421,8 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge
 		let inputModel = this.modelService.getModel(this.inputUri);
 		if (!inputModel) {
 			inputModel = this.modelService.createModel('', null, this.inputUri, true);
+			this._register(inputModel);
 		}
-		this._register(inputModel);
 
 		this.textModelResolverService.createModelReference(this.inputUri).then(ref => {
 			// make sure to hold a reference so that the model doesn't get disposed by the text model service

Original file line number	Diff line number	Diff line change
`@@ -2421,8 +2421,8 @@ export class ChatInputPart extends Disposable implements IHistoryNavigationWidge`
`2421`	`2421`	`let inputModel = this.modelService.getModel(this.inputUri);`
`2422`	`2422`	`if (!inputModel) {`
`2423`	`2423`	`inputModel = this.modelService.createModel('', null, this.inputUri, true);`
	`2424`	`+ this._register(inputModel);`
`2424`	`2425`	`}`
`2425`		`- this._register(inputModel);`
`2426`	`2426`
`2427`	`2427`	`this.textModelResolverService.createModelReference(this.inputUri).then(ref => {`
`2428`	`2428`	`// make sure to hold a reference so that the model doesn't get disposed by the text model service`