Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native REPL should start on the project folder #23821

Closed
heliosdrm opened this issue Jul 16, 2024 · 4 comments
Closed

Native REPL should start on the project folder #23821

heliosdrm opened this issue Jul 16, 2024 · 4 comments
Assignees
Labels
area-repl bug Issue identified by VS Code Team member as probable bug good first issue needs PR Ready to be worked on on-testplan Added to test plan
Milestone

Comments

@heliosdrm
Copy link

After starting the native REPL:

import os
os.getcwd()

does not return the project folder as expected, but the folder that contains the VS Code executable.

@heliosdrm heliosdrm added the feature-request Request for new features or functionality label Jul 16, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jul 16, 2024
@karthiknadig karthiknadig added bug Issue identified by VS Code Team member as probable bug and removed feature-request Request for new features or functionality labels Jul 16, 2024
@karthiknadig
Copy link
Member

Looks like the cwd is not set when launching the REPL server.

@karthiknadig karthiknadig added good first issue needs PR Ready to be worked on labels Jul 16, 2024
@github-actions github-actions bot added the info-needed Issue requires more information from poster label Jul 16, 2024
@karthiknadig karthiknadig added area-repl and removed info-needed Issue requires more information from poster triage-needed Needs assignment to the proper sub-team labels Jul 16, 2024
@anthonykim1 anthonykim1 added this to the August 2024 milestone Aug 6, 2024
@anthonykim1
Copy link

As mentioned in #23656 (comment), working to set proper directory for when REPL launches.

anthonykim1 added a commit that referenced this issue Aug 7, 2024
Resolves: #23727 

Allow users to launch Native REPL via command palette.

Will also be handling
#23821 in this PR. --
setting proper workspace directory.
Related: #23656 

Covering scenarios:
- Provide selection option if user is in multi-workspace scenario
(already included in PR)
- Automatically pick workspace as directory for context of REPL if user
is in single-workspace scenario (already included in PR)
- Handle case where user does not open any workspace and attempt to
launch native REPL from plain/empty VS Code instance via command palette
option (already included in PR)
@anthonykim1
Copy link

anthonykim1 commented Aug 9, 2024

This should be resolved as #23912 got merged. Feel free to give this a try in latest pre-release version of Python extension! @heliosdrm

@anthonykim1 anthonykim1 added the verification-needed Verification of issue is requested label Aug 9, 2024
@anthonykim1
Copy link

Moving this to a dedicated TPI since we want to make sure to cover all different scenario of: empty workspace, single workspace, multiple workspace scenario.

@anthonykim1 anthonykim1 removed the verification-needed Verification of issue is requested label Aug 26, 2024
@anthonykim1 anthonykim1 added the on-testplan Added to test plan label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-repl bug Issue identified by VS Code Team member as probable bug good first issue needs PR Ready to be worked on on-testplan Added to test plan
Projects
None yet
Development

No branches or pull requests

3 participants