Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support correct execution status for native REPL #23739

Closed
anthonykim1 opened this issue Jul 3, 2024 · 4 comments · Fixed by #23797
Closed

Support correct execution status for native REPL #23739

anthonykim1 opened this issue Jul 3, 2024 · 4 comments · Fixed by #23797
Assignees
@anthonykim1
Labels
area-repl feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team verification-needed Verification of issue is requested verified Verification succeeded
Milestone
July 2024

Comments

@anthonykim1
Copy link

In the native REPL, we should correctly mark the execution status as either failure (red x mark) or success (green check mark) depending on the output of the user's code execution.

For example, if import failed, we should not only tell the uiser that the import failed but also mark the cell of the native REPL to show red x mark failure status.
@anthonykim1 anthonykim1 added feature-request Request for new features or functionality area-repl labels Jul 3, 2024
@anthonykim1 anthonykim1 added this to the July 2024 milestone Jul 3, 2024
@anthonykim1 anthonykim1 self-assigned this Jul 3, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jul 3, 2024
@anthonykim1 anthonykim1 removed the triage-needed Needs assignment to the proper sub-team label Jul 3, 2024
@kieferrm kieferrm mentioned this issue Jul 7, 2024
Closed
25 tasks
@anthonykim1 anthonykim1 mentioned this issue Jul 11, 2024
Merged
@karthiknadig karthiknadig added the verification-needed Verification of issue is requested label Jul 23, 2024
@karthiknadig
Copy link
Member

Verification Steps:

  1. Run some code in python REPL.
  2. If it succeeds it should have a tick mark, else it should show failed status

@rzhao271
Copy link

Failing commands are getting checkmarks too

Second and fourth commands have tracebacks but also checkmarks

@rzhao271 rzhao271 reopened this Jul 23, 2024
@rzhao271 rzhao271 added the verification-found Issue verification failed label Jul 23, 2024
@github-actions github-actions bot added the triage-needed Needs assignment to the proper sub-team label Jul 23, 2024
@anthonykim1
Copy link
Author

@rzhao271 Can you please update Python extension to latest and retry?
Couldnt really repro
Screenshot 2024-07-23 at 11 27 30 PM

@rzhao271
Copy link

It's good now

@rzhao271 rzhao271 added verified Verification succeeded and removed verification-found Issue verification failed labels Jul 24, 2024
eleanorjboyd pushed a commit to eleanorjboyd/vscode-python that referenced this issue Jul 30, 2024
@anthonykim1 @eleanorjboyd
Correctly display native REPL execution status (microsoft#23797)
ef8b8c8 
Resolves: microsoft#23739
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@anthonykim1 anthonykim1

Labels
area-repl feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
July 2024
Development

Successfully merging a pull request may close this issue.

Correctly display native REPL execution status anthonykim1/vscode-python
3 participants
@karthiknadig @rzhao271 @anthonykim1