Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments don't show on non-checked out PR when closing and re-opening the file from the PRs veiw #6571

Closed
catskul opened this issue Dec 19, 2024 · 2 comments · Fixed by #6573
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@catskul
Copy link

catskul commented Dec 19, 2024

When working on stacked PRs it's common to want to address comments on a lower PR in the stack while having the branch from a higher PR checked out.

At the moment it seems that GithubPullRequests extension will not allow this even when a PR file or diff is opened in preview mode from the Pull Requests sidebar.

IMO the comments should still appear in these editor windows at the very least, and ideally in any file with comments.

@catskul
Copy link
Author

catskul commented Dec 19, 2024

This might actually be a bug?

Sometimes I can see the comments and sometimes I cant see the comments when opening the file from the pull requests panel. (the editor says file_name.cc (Pull Request))

It seems like the first time I open the file after restarting VsCode, the comments are visible, but if I close and re-open the editor tab, they disappear and never come back until I restart vscode.

I've tried with both insiders (1.97.0-insider), and normal vscode (1.96.2) and have tried with both the release (0.102.0) and pre-release (0.103.2024121904) version of the vscode-github-pull-requests extension with no difference in behavior.

@alexr00 alexr00 self-assigned this Dec 20, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Dec 20, 2024
@alexr00 alexr00 added this to the January 2025 milestone Dec 20, 2024
@alexr00
Copy link
Member

alexr00 commented Dec 20, 2024

It is a bug, and apparently it's been around for nearly a year. Thanks for reporting!

@alexr00 alexr00 changed the title View PR comments when on stacked PRs/branches Comments don't show on non-checked out PR when closing and re-opening the file from the PRs veiw Dec 20, 2024
alexr00 added a commit that referenced this issue Dec 20, 2024
alexr00 added a commit that referenced this issue Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
2 participants