Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Primary action to "Start Review" is not looking as such #6553

Closed
bpasero opened this issue Dec 17, 2024 · 4 comments · Fixed by microsoft/vscode#236325
Closed

Primary action to "Start Review" is not looking as such #6553

bpasero opened this issue Dec 17, 2024 · 4 comments · Fixed by microsoft/vscode#236325
Assignees
@alexr00
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone
January 2025

Comments

@bpasero
Copy link
Member

bpasero commented Dec 17, 2024

My feeling is that "Start Review" is typically the primary action on a PR:

Image

But here the button looks secondary. I would make "Start Review" green and the others dark.
@alexr00
Copy link
Member

alexr00 commented Dec 17, 2024

You can choose which one is primary: githubPullRequests.defaultCommentType

@alexr00
Copy link
Member

alexr00 commented Dec 17, 2024

The "Make a Suggestion" button shouldn't be a primary button though.

@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Dec 17, 2024
@alexr00 alexr00 added this to the January 2025 milestone Dec 17, 2024
alexr00 added a commit to microsoft/vscode that referenced this issue Dec 17, 2024
@alexr00
Fix extra primary button in comments
09aaf81 
Fixes microsoft/vscode-pull-request-github#6553
@alexr00 alexr00 mentioned this issue Dec 17, 2024
Merged
alexr00 added a commit to microsoft/vscode that referenced this issue Dec 17, 2024
@alexr00
Fix extra primary button in comments (#236325)
f78af53 
Fixes microsoft/vscode-pull-request-github#6553
@bpasero
Copy link
Member Author

bpasero commented Dec 17, 2024

Should we make review the default?

@alexr00
Copy link
Member

alexr00 commented Dec 17, 2024

I think we'll end up with a lot of confused users since it's very easy to make a bunch of "review" comments and then forget to submit the review. This results in a bunch of comments that no one but you ever sees since they are associated with an unsubmitted review.

@alexr00 alexr00 mentioned this issue Dec 18, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexr00 alexr00

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
January 2025
Development

Successfully merging a pull request may close this issue.

Fix extra primary button in comments microsoft/vscode
2 participants
@bpasero @alexr00