"Resolve Conversation" button does not close panel with commen.

[alexanderilyin]

Related PRs

• https://github.com/partcad/partcad/pull/228/files

Summary

Type: Bug

Neither using "Resolve Conversation" nor context menu in the Comments panel marks comment as resolved, but logs tell me that it happened but it did not:

2024-12-15 05:13:20.710 [debug] PullRequestModel> Resolve review thread - enter
2024-12-15 05:13:20.710 [debug] RateLimit> Extension rate limit remaining: 140, undefined
2024-12-15 05:13:21.382 [debug] RateLimit> GraphQL Rate limit remaining: undefined, cost: undefined, undefined
2024-12-15 05:13:21.383 [info] PullRequestTree> Review threads have changed, refreshing Files node
2024-12-15 05:13:21.383 [info] PullRequestTree> Review threads have changed, refreshing Commits node
2024-12-15 05:13:21.383 [debug] PullRequestModel> Resolve review thread - done

Extension version: 0.102.0
VS Code version: Code 1.96.0 (138f619c86f1199955d53b4166bef66ef252935c, 2024-12-11T02:29:09.626Z)
OS version: Windows_NT x64 10.0.19045
Modes:
Remote OS version: Linux x64 5.15.153.1-microsoft-standard-WSL2

System Info

Item	Value
CPUs	AMD Ryzen 9 3900X 12-Core Processor (24 x 3793)
GPU Status	2d_canvas: enabled canvas_oop_rasterization: enabled_on direct_rendering_display_compositor: disabled_off_ok gpu_compositing: enabled multiple_raster_threads: enabled_on opengl: enabled_on rasterization: enabled raw_draw: disabled_off_ok skia_graphite: disabled_off video_decode: enabled video_encode: enabled vulkan: disabled_off webgl: enabled webgl2: enabled webgpu: enabled webnn: disabled_off
Load (avg)	undefined
Memory (System)	79.91GB (51.08GB free)
Process Argv	--crash-reporter-id 828c2b46-e47b-405a-9312-09a86750d998
Screen Reader	no
VM	0%

Item	Value
Remote	Dev Container: PartCAD Dev Container @ desktop-linux
OS	Linux x64 5.15.153.1-microsoft-standard-WSL2
CPUs	AMD Ryzen 9 3900X 12-Core Processor (24 x 0)
Memory (System)	39.13GB (34.24GB free)
VM	0%

A/B Experiments

vsliv368cf:30146710
vspor879:30202332
vspor708:30202333
vspor363:30204092
vscod805:30301674
binariesv615:30325510
vsaa593cf:30376535
py29gd2263:31024239
c4g48928:30535728
azure-dev_surveyone:30548225
962ge761:30959799
pythonnoceb:30805159
pythonmypyd1:30879173
h48ei257:31000450
pythontbext0:30879054
cppperfnew:31000557
dsvsc020:30976470
pythonait:31006305
dsvsc021:30996838
dvdeprecation:31068756
dwnewjupyter:31046869
nativerepl2:31139839
pythonrstrctxt:31112756
nativeloc2:31192216
cf971741:31144450
iacca1:31171482
notype1cf:31157160
5fd0e150:31155592
dwcopilot:31170013
stablechunks:31184530
6074i472:31201624

Also my PR in Web UI is broken:

• https://github.com/partcad/partcad/pull/228/files#diff-63a9c44a44acf85fea213a857769990937107cf072831e1a26808cfde9d096b9 aka .pre-commit-config.yaml

[alexanderilyin]

Attempt to delete comment in VS Code UI also has no effect and produces the following logs:

2024-12-15 05:20:05.531 [debug] RateLimit> Extension rate limit remaining: 140, /repos/{owner}/{repo}/issues/comments/{comment_id}
2024-12-15 05:20:05.532 [debug] RateLimit> Extension rate limit remaining: 139, GetPendingReviewId
2024-12-15 05:20:05.940 [debug] RateLimit> GraphQL Rate limit remaining: 3117, cost: 1, GetPendingReviewId
2024-12-15 05:20:05.944 [debug] RateLimit> Extension rate limit remaining: 140, GetPendingReviewId
2024-12-15 05:20:06.337 [debug] RateLimit> GraphQL Rate limit remaining: 3116, cost: 1, GetPendingReviewId

[alexr00]

This seems like a transient GitHub issue. Are you still seeing the comment not be resolved?

[alexanderilyin]

@alexr00 I bump into it once in a while, it's also only affect specific comments while others are not affected.