You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When posting a comment on a specific line of code, between the buttons on github.com and the extention, there is ordering and highlighting differences that make the process extremely confusing when jumping between the two.
For each of these, the buttons are ordered as:
github.com: cancel, add single comment, start a review
VS code github PR extention: make a suggestion, start a review, add comment
And in both cases the last button is in the highlight color.
I think I understand why the first button is different (something about UI guidelines I guess), but the 2nd and 3rd feel like they are plainly trying to make me do the wrong action.
Extension version: 0.100.3
VS Code version: Code 1.95.3 (f1a4fb101478ce6ec82fe9627c43efbf9e98c813, 2024-11-13T14:50:04.152Z)
OS version: Windows_NT x64 10.0.19044
Modes:
The text was updated successfully, but these errors were encountered:
We have a setting for this githubPullRequests.defaultCommentType.
I'm always a bit hesitant to change the defaults as it can break muscle memory, especially since it can be tough for user to figure out that they need to submit a review for their comments to become visible. I'm going to leave the default as is since you can change the default with the setting.
Type: Bug
When posting a comment on a specific line of code, between the buttons on github.com and the extention, there is ordering and highlighting differences that make the process extremely confusing when jumping between the two.
For each of these, the buttons are ordered as:
cancel
,add single comment
,start a review
make a suggestion
,start a review
,add comment
And in both cases the last button is in the highlight color.
I think I understand why the first button is different (something about UI guidelines I guess), but the 2nd and 3rd feel like they are plainly trying to make me do the wrong action.
Extension version: 0.100.3
VS Code version: Code 1.95.3 (f1a4fb101478ce6ec82fe9627c43efbf9e98c813, 2024-11-13T14:50:04.152Z)
OS version: Windows_NT x64 10.0.19044
Modes:
The text was updated successfully, but these errors were encountered: