Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistency between buttons in PR comments #6518

Closed
Henri-ColibrITD opened this issue Dec 9, 2024 · 2 comments
Closed

Inconsistency between buttons in PR comments #6518

Henri-ColibrITD opened this issue Dec 9, 2024 · 2 comments

Comments

@Henri-ColibrITD
Copy link

Type: Bug

When posting a comment on a specific line of code, between the buttons on github.com and the extention, there is ordering and highlighting differences that make the process extremely confusing when jumping between the two.
For each of these, the buttons are ordered as:

  • github.com: cancel, add single comment, start a review
  • VS code github PR extention: make a suggestion, start a review, add comment

And in both cases the last button is in the highlight color.

I think I understand why the first button is different (something about UI guidelines I guess), but the 2nd and 3rd feel like they are plainly trying to make me do the wrong action.

Extension version: 0.100.3
VS Code version: Code 1.95.3 (f1a4fb101478ce6ec82fe9627c43efbf9e98c813, 2024-11-13T14:50:04.152Z)
OS version: Windows_NT x64 10.0.19044
Modes:

@Henri-ColibrITD
Copy link
Author

So you have in mind exactly what I mean, here are screenshots of the corresponding bits of UI:

  • github.com: Image
  • VS code github PR extention: Image

@alexr00
Copy link
Member

alexr00 commented Dec 13, 2024

We have a setting for this githubPullRequests.defaultCommentType.

I'm always a bit hesitant to change the defaults as it can break muscle memory, especially since it can be tough for user to figure out that they need to submit a review for their comments to become visible. I'm going to leave the default as is since you can change the default with the setting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants