Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error when adding file comment to renamed file w/o other changes #6516

Closed
diminutivesloop opened this issue Dec 6, 2024 · 1 comment · Fixed by #6538
Closed

error when adding file comment to renamed file w/o other changes #6516

diminutivesloop opened this issue Dec 6, 2024 · 1 comment · Fixed by #6538
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@diminutivesloop
Copy link

diminutivesloop commented Dec 6, 2024

  • Extension version:
  • VSCode Version: 1.95.3
  • OS: Darwin x64 23.6.0
  • Repository Clone Configuration (single repository/fork of an upstream repository): single repository
  • Github Product (Github.com/Github Enterprise version x.x.x): Github.com

Steps to Reproduce:

  1. In a pull request open a change diff for a file that was renamed without any other changes.
  2. Click the "Add file comment" editor action button.

The following error shows: "The cursor must be within a commenting range to add a comment"

@alexr00
Copy link
Member

alexr00 commented Dec 13, 2024

🙏 a huge thank you for reporting this. I have been unable to find the source of microsoft/vscode#230642, but your steps cause it!

@alexr00 alexr00 self-assigned this Dec 13, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Dec 13, 2024
@alexr00 alexr00 added this to the January 2025 milestone Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
2 participants