Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow builtin VSCode behavior by respecting git.showInlineOpenFileAction #6515

Closed
ian-h-chamberlain opened this issue Dec 6, 2024 · 0 comments · Fixed by #6539
Closed
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@ian-h-chamberlain
Copy link

The default "Source Control" view uses git.showInlineOpenFileAction to decide whether to display an extra button to quickly open a changed file (vs the diff), and also swaps the behavior of the button based on git.openDiffOnClick (does the opposite of clicking the filename itself).

By contrast, this extension always shows the inline "Open File" button, and its behavior is always to open the file, which is redundant when clicking the filename will open the file (instead of the diff).

Examples of the Source Control view's behavior:

Clicking the button here does the "open file" action:

{
    "git.openDiffOnClick": true,
    "git.showInlineOpenFileAction": true,
}

Image


Clicking the button here opens the diff instead, since clicking the filename opens the file:

{
    "git.openDiffOnClick": false,
    "git.showInlineOpenFileAction": true,
}

Image


The button is completely hidden in this case:

{
    "git.showInlineOpenFileAction": false,
}

Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality
Projects
None yet
2 participants