Skip to content

Follow builtin VSCode behavior by respecting git.showInlineOpenFileAction #6515

Closed
@ian-h-chamberlain

Description

@ian-h-chamberlain

The default "Source Control" view uses git.showInlineOpenFileAction to decide whether to display an extra button to quickly open a changed file (vs the diff), and also swaps the behavior of the button based on git.openDiffOnClick (does the opposite of clicking the filename itself).

By contrast, this extension always shows the inline "Open File" button, and its behavior is always to open the file, which is redundant when clicking the filename will open the file (instead of the diff).

Examples of the Source Control view's behavior:

Clicking the button here does the "open file" action:

{
    "git.openDiffOnClick": true,
    "git.showInlineOpenFileAction": true,
}

Image


Clicking the button here opens the diff instead, since clicking the filename opens the file:

{
    "git.openDiffOnClick": false,
    "git.showInlineOpenFileAction": true,
}

Image


The button is completely hidden in this case:

{
    "git.showInlineOpenFileAction": false,
}

Image

Metadata

Metadata

Assignees

Labels

feature-requestRequest for new features or functionalityverification-neededVerification of issue is requestedverifiedVerification succeeded

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions