Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No PR changes displayed for a specific repo on any PR. #6513

Open
mikebronner opened this issue Dec 5, 2024 · 10 comments
Open

No PR changes displayed for a specific repo on any PR. #6513

mikebronner opened this issue Dec 5, 2024 · 10 comments
Labels
info-needed Issue requires more information from poster

Comments

@mikebronner
Copy link

  • Extension version: 0.100.3
  • VSCode Version: 1.95.3
  • OS: macOS 14.0 (23A344)
  • Repository Clone Configuration: git clone .....
  • Github Product: Github Team

Steps to Reproduce:

  1. Open repo locally.
  2. Checkout a PR.
  3. Select the Activity Bar tab "Github Pull Request".
  4. Watch the "Changes in Pull Request #..." section load endlessly.

The output panel for Github Pull Requests extension has the following output:

2024-12-05 13:21:34.122 [info] GitHubRepository+0> Fetch branch develop - done: true
2024-12-05 13:21:34.127 [info] Review+0> Resolved PR #157, state is 0
2024-12-05 13:21:34.127 [info] Review+0> Fetching pull request data
2024-12-05 13:21:34.128 [info] PullRequestTree> Adding PR #157 to tree
2024-12-05 13:21:34.163 [info] Review+0> Register comments provider
2024-12-05 13:21:34.164 [info] Review+0> Register in memory content provider
2024-12-05 13:21:35.577 [info] PullRequestTree> Creating file and commit nodes for PR #157
2024-12-05 13:21:35.578 [info] PullRequestTree> Getting children for Files node
2024-12-05 13:21:45.230 [error] Review+0> Failed to initialize PR data HttpError: Server Error
2024-12-05 13:21:45.297 [error] Review+0> Failed to register in mem content provider: HttpError: Server Error
2024-12-05 13:21:45.297 [info] Review+0> Display pull request status bar indicator.
2024-12-05 13:21:45.298 [info] Review+0> Using focus mode = true.
2024-12-05 13:21:45.298 [info] Review+0> State validation silent = true.
2024-12-05 13:21:45.298 [info] Review+0> PR show should show = false.

Unfortunately there aren't more details that would indicate the precise error that is being shown in the API calls. Anything I can do to investigate this better, perhaps make some API calls using curl? I would need guidance on exactly which commands to run.

@alexr00
Copy link
Member

alexr00 commented Dec 13, 2024

@mikebronner is this with GitHub Enterprise?

@alexr00 alexr00 added the info-needed Issue requires more information from poster label Dec 13, 2024
@mikebronner
Copy link
Author

@mikebronner is this with GitHub Enterprise?

I don't believe so. This is the org: https://github.com/CrossBibleInc

@alexr00
Copy link
Member

alexr00 commented Dec 17, 2024

Is it a private repo in https://github.com/CrossBibleInc?

@mikebronner
Copy link
Author

yes

@alexr00
Copy link
Member

alexr00 commented Dec 17, 2024

I think something might be wrong with your auth token. Could you try the following:

  1. From the accounts menu in VS Code, sign out of your GitHub account
  2. Reload the VS Code window
  3. Sign in again

@mikebronner
Copy link
Author

mikebronner commented Dec 17, 2024

I have tried that several times in the past, and just now again, issue persists. I do not believe it is my GitHub connection settings in VSCode, as other repos in other organizations work just fine.

@alexr00
Copy link
Member

alexr00 commented Dec 17, 2024

as other repos in other organizations work just fine.

This is precisely the reason I do think it's an issue with your auth token, as different orgs can have different auth requirements.

When you sign in to GitHub through VS Code, do you get taken to GitHub web page that asks about single sign on? For example, with the orgs that I belong to, this is the one that I see.

Image

@mikebronner
Copy link
Author

This is what I see:
Image
and then:
Image

@alexr00
Copy link
Member

alexr00 commented Dec 18, 2024

Hmm. You don't see any other page after hitting continue?

@TylerLeonhardt do you know of any way @mikebronner could check if the auth token they have for GitHub in VS Code is missing the access required for a public org's private repos?

@TylerLeonhardt
Copy link
Member

Hmm this doesn't really add up to me. These tokens shouldn't have access to only some orgs unless this organization uses SAML (aka Single Sign On) but if it did, you'd get the screenshot that @alexr00 shared.

@alexr00 can we get any more details on this error besides "HttpError: Server Error"? Also, doesn't that usually mean 500 so this would be a GitHub API bug?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info-needed Issue requires more information from poster
Projects
None yet
Development

No branches or pull requests

3 participants