Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review/Comment Suggestions are offset by one line if you make local changes first #6495

Closed
gabeseltzer opened this issue Nov 19, 2024 · 1 comment · Fixed by #6566
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug
Milestone

Comments

@gabeseltzer
Copy link

  • Extension version: v0.100.3 and v0.101.2024111911
  • VSCode Version: 1.95.3
  • OS: Windows
  • Repository Clone Configuration: single repository
  • Github Product Github.com

Steps to Reproduce:

See video:

Carnac_9EC2yeeg1G.mp4
  1. Create a simple repo
  2. (open vscode with temporary profile, so no conflicting extensions)
  3. (log in to github, all that jazz)
  4. Create a branch + PR for your simple repo (here's mine from the video: a change to put in a pr gabeseltzer/tv-mode#1)
  5. Refresh the PR viewer so that it sees the open PR
  6. Make a change to a line that was modified in the PR (or a line nearby)
  7. Save the file (optional, I did it in the video, but I have tested and it isn't necessary)
  8. Press the + icon in the gutter to create a comment
  9. Press "Make a Suggestion" (you can add additional comments, it doesn't matter)
  10. Confirm the suggestion with either "Start Review" or "Add Comment" (Also works if you already have a review open)
  11. Open Github and refresh the PR, and you'll see the suggestion is on the wrong line, it's one line down!
  12. (not in video) If you close and re-open VSCode, the comment will show in the line below the one you added it to, just like the Github website.
@alexr00 alexr00 self-assigned this Dec 2, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Dec 2, 2024
@alexr00 alexr00 added this to the January 2025 milestone Dec 2, 2024
@alexr00
Copy link
Member

alexr00 commented Dec 18, 2024

Thank you for reporting!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
2 participants