Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestions end up in unsubmittable pending state #6494

Closed
MetRonnie opened this issue Nov 19, 2024 · 2 comments · Fixed by #6504
Closed

Suggestions end up in unsubmittable pending state #6494

MetRonnie opened this issue Nov 19, 2024 · 2 comments · Fixed by #6504
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@MetRonnie
Copy link

MetRonnie commented Nov 19, 2024

  • Extension version: v0.100.0
  • VSCode Version: 1.95.3 (system setup)
  • OS: Windows_NT x64 10.0.19045
  • Repository Clone Configuration: fork of an upstream repository
  • Github Product: Github.com

Steps to Reproduce:

  1. Make multiple changes to different "hunks" in a file and click the "Create pull request suggestions" button in the Source Control panel

    Here my suggestions ended up as 4 pending comments:

    gh-pr-bug-3-p1.mp4
  2. This can lead to multiple individual reviews being started on GitHub and only being able to submit a subset of the suggestions in the review

    On the GH website only 1 comment is in the review:

    gh-pr-bug-3-p2.mp4

    The other comments end up stuck as pending and cannot be submitted in a review

This is superficially similar to #4291, but in this case the comments clearly are making their way to the server in the pending state, but cannot be submitted.

#1317 may also be relevant

@alexr00 alexr00 self-assigned this Dec 2, 2024
@alexr00 alexr00 added the bug Issue identified by VS Code Team member as probable bug label Dec 2, 2024
@alexr00 alexr00 added this to the November 2024 milestone Dec 2, 2024
@alexr00
Copy link
Member

alexr00 commented Dec 2, 2024

Thanks for reporting! Looks like GitHub's API doesn't handle us trying to create all the comment threads in parallel very well. I'm making a change to do the first file in sequence, then do all the others in parallel.

@alexr00
Copy link
Member

alexr00 commented Dec 3, 2024

To verify:

  1. Check out a PR with at least 15 changed lines across at least 2 files.
  2. Make at least 4 changes on lines that you can comment on. Make these changes in such a way that there are 2 unchanged lines between changed lines. Make these changes across at least two files.
  3. From the SCM view, use the action in the original post to convert your changes to suggestions.
  4. Verify that all your changes were converted to suggestions.
  5. Submit your review. Verify that all your suggestions no longer say "Pending".

@roblourens roblourens added the verified Verification succeeded label Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants