You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Repository Clone Configuration: fork of an upstream repository
Github Product: Github.com
Steps to Reproduce:
Make multiple changes to different "hunks" in a file and click the "Create pull request suggestions" button in the Source Control panel
Here my suggestions ended up as 4 pending comments:
gh-pr-bug-3-p1.mp4
This can lead to multiple individual reviews being started on GitHub and only being able to submit a subset of the suggestions in the review
On the GH website only 1 comment is in the review:
gh-pr-bug-3-p2.mp4
The other comments end up stuck as pending and cannot be submitted in a review
This is superficially similar to #4291, but in this case the comments clearly are making their way to the server in the pending state, but cannot be submitted.
Thanks for reporting! Looks like GitHub's API doesn't handle us trying to create all the comment threads in parallel very well. I'm making a change to do the first file in sequence, then do all the others in parallel.
Check out a PR with at least 15 changed lines across at least 2 files.
Make at least 4 changes on lines that you can comment on. Make these changes in such a way that there are 2 unchanged lines between changed lines. Make these changes across at least two files.
From the SCM view, use the action in the original post to convert your changes to suggestions.
Verify that all your changes were converted to suggestions.
Submit your review. Verify that all your suggestions no longer say "Pending".
Steps to Reproduce:
Make multiple changes to different "hunks" in a file and click the "Create pull request suggestions" button in the Source Control panel
Here my suggestions ended up as 4 pending comments:
gh-pr-bug-3-p1.mp4
This can lead to multiple individual reviews being started on GitHub and only being able to submit a subset of the suggestions in the review
On the GH website only 1 comment is in the review:
gh-pr-bug-3-p2.mp4
The other comments end up stuck as pending and cannot be submitted in a review
This is superficially similar to #4291, but in this case the comments clearly are making their way to the server in the pending state, but cannot be submitted.
#1317 may also be relevant
The text was updated successfully, but these errors were encountered: