-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension fails to detect PR branch when using gh co <PR>
#6378
Comments
I'm not able to repro. Can you share the following:
|
The Repo is not a fork - it's freqtrade/freqtrade (though i do have a fork - the Pull request is not against a fork - but from a fork). on that repo - i tried it's a random repro using the very latest PR at this point (one i'm sure i haven't had checked out before). After clicking the "reload" button several times: with
If i do the checkout via the extension (rightclick on the PR line - Checkout Pull Request) - i get the branch name |
Thanks that was helpful in narrowing down where the issue might be. I'm still not able to repro though. Can you try the following:
|
The only 2 settings i've got set (different from default) are the following two (the latter of which i've tried to remove now - to no avail).
the interesting part is - if i run into this - and then run "restart extension hots" - then it detects the PR. deleting that same branch - and doing the checkout again - i'm again stuck with the extension not detecting this.
Potentially interesting log
starts at the "git checkout fix-test-download-data-timerange" - as far as i can tell
It's interesting that it first knows "ah, this branch is PR xxx" - and then "no metadata ... no clue what this is" (at the last 2-3 lines). |
An additional point to notice: Additional logs from the extension output
|
the Github Pull Requests extension fails to properly detect pull request branches created by
gh co <prnr>
.This breaks flow - as i like the github cli to interact with the repo - but need the extension for the review (where it's great).
I know i could check out via extension, but i very often forget this - so i need to go back to the main branch, checkout the PR branch via extension - just to have the extension realize that this is a pull request branch.
Steps to Reproduce:
gh pr list
to get a Pull request numbergh co <prnr>
(your repository will now have a different branch checked out)In my memory (might be wrong?) this used to work a few months ago - but then stopped working. (i'm opening this issue only now as i hoped that someone else would report this so i don't have to 😆 )
The text was updated successfully, but these errors were encountered: