Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variable expansion problem with launch config/userDataDir #2472

Open
shanto opened this issue Oct 8, 2024 · 3 comments
Open

Variable expansion problem with launch config/userDataDir #2472

shanto opened this issue Oct 8, 2024 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@shanto
Copy link

shanto commented Oct 8, 2024

Environment (please complete the following information):

  • OS Windows 11:
  • Extension version 2.1.6:

Describe the bug:
When a custom userDataDir is specified, variables inside the value is not expanded.

Repro steps:
Define a launch config as:

{
  "name": "EdgeBrowserInternal",
  "userDataDir": "${workspaceFolder}/.vscode/edge",
  "type": "vscode-edge-devtools.debug",
  "request": "launch",
  "webRoot": "${workspaceFolder}"
}

Expected behavior:
Edge should launch with the profile directory as specified.

Additional context:
${workspaceFolder} specified above inside userDataDir is not expanded. Edge fails to launch with a custom profile, and falls back to default profile.
image

@vidorteg
Copy link
Contributor

vidorteg commented Oct 9, 2024

This seems to be a request for the Edge team, please report it using the Feedback button in Edge.

@vidorteg vidorteg closed this as completed Oct 9, 2024
@shanto
Copy link
Author

shanto commented Oct 9, 2024

This seems to be a request for the Edge team, please report it using the Feedback button in Edge.

Actually not. It is the devtools VSCode extension which is not processing variables like these and passing it as-is to msedge.exe, I have verified this from edge://version. Edge is not supposed to recognize ${workspaceFolder}. It's VSCode's job to expand it and pass the processed path to msedge.exe. For everything else ${workspaceFolder} is expanded as expected. So, the problem definitely lies within the DevTools extension.

@vidorteg
Copy link
Contributor

vidorteg commented Nov 8, 2024

Reopening this issue.

@vidorteg vidorteg self-assigned this Nov 8, 2024
@vidorteg vidorteg added the bug Something isn't working label Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants