Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[restbed] fix static windows linkage #42422

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[restbed] fix static windows linkage #42422

wants to merge 2 commits into from
+285 −33

Conversation

JulZimmermann
Copy link
Contributor

@JulZimmermann JulZimmermann commented Nov 29, 2024 •
edited by WangWeiLin-MV
Loading

Allow static linkage on windows, by not defining dllexport and dllinport when build statically.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

@WangWeiLin-MV WangWeiLin-MV added the category:port-bug The issue is with a library, which is something the port should already support label Nov 29, 2024
WangWeiLin-MV
WangWeiLin-MV reviewed Nov 29, 2024
View reviewed changes
ports/restbed/fix-windows-static.patch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. Since new macro added in the source code, please submit this fix upstream.

@WangWeiLin-MV WangWeiLin-MV added the depends:upstream-changes Waiting on a change to the upstream project label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV left review comments

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-bug The issue is with a library, which is something the port should already support depends:upstream-changes Waiting on a change to the upstream project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JulZimmermann @WangWeiLin-MV