Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sese] Workaround to download from correct codeload.github URL #42420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

WangWeiLin-MV
Copy link
Contributor

See #42407 (comment)

GitHub assets download with ambiguous tag redirect to the wrong URL

Assets: https://github.com/libsese/sese/archive/refs/tags/2.3.0.tar.gz
Wrong: https://codeload.github.com/libsese/sese/tar.gz/2.3.0/tags/2.3.0
Expect: https://codeload.github.com/libsese/sese/tar.gz/refs/tags/2.3.0

So, download directly from correct URL as workaround.

Note, the link REF is part of directory in archive, if download from commit URL, the file hash will be different. And as a redirect URL, it might change in the future. This issue is tracked by comment above.

Checklist

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Test

With no assets cache, the port installation tests pass with the following triplets:

  • x64-windows
  • x64-linux

@WangWeiLin-MV WangWeiLin-MV added category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. labels Nov 29, 2024
@WangWeiLin-MV WangWeiLin-MV marked this pull request as ready for review November 29, 2024 04:48
@JonLiu1993 JonLiu1993 added the info:reviewed Pull Request changes follow basic guidelines label Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-bug The issue is with a library, which is something the port should already support info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants