Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[influxdb-cxx] Update to v0.7.1 #31145

Merged

Conversation

MonicaLiu0311
Copy link
Contributor

@MonicaLiu0311 MonicaLiu0311 commented Apr 27, 2023

Fixes #31092.

  • Update to v0.7.1.

  • The upstream dependency curl has been removed, and cpr has been added, see: v0.7.1#installation.

  • LNK2001 and LNK2019 occur because InfluxDB_EXPORTS is not defined during dynamic linking, add fix-dllexports.patch to fix it. Reported upstream: offa/influxdb-cxx#194.

    TCP.cxx.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: __cdecl influxdb::InfluxDBException::InfluxDBException(class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> > const &)" (__imp_??0InfluxDBException@influxdb@@QEAA@AEBV?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@Z)
    InfluxDB.cxx.obj : error LNK2019: unresolved external symbol "__declspec(dllimport) public: __cdecl influxdb::Point::~Point(void)" (__imp_??1Point@influxdb@@QEAA@XZ) referenced in function "public: void * __cdecl influxdb::Point::`scalar deleting destructor'(unsigned int)" (??_GPoint@influxdb@@QEAAPEAXI@Z)
    
  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.
  • All features are tested successfully in the following triplet:
x86-windows
x64-windows
x64-windows-static
  • The usage test passed (header files found):
influxdb-cxx provides CMake targets:

    # this is heuristically generated, and may not be correct
    find_package(InfluxDB CONFIG REQUIRED)
    target_link_libraries(main PRIVATE InfluxData::InfluxDB)

@MonicaLiu0311 MonicaLiu0311 added info:internal This PR or Issue was filed by the vcpkg team. category:port-update The issue is with a library, which is requesting update new revision labels Apr 27, 2023
@MonicaLiu0311 MonicaLiu0311 added the depends:upstream-changes Waiting on a change to the upstream project label Apr 27, 2023
@MonicaLiu0311
Copy link
Contributor Author

The commit that caused the error has been located, but the upstream has not found the reason for the time being and cannot be modified, so continue this PR.

@MonicaLiu0311 MonicaLiu0311 removed the depends:upstream-changes Waiting on a change to the upstream project label May 17, 2023
@MonicaLiu0311 MonicaLiu0311 marked this pull request as ready for review May 17, 2023 06:24
@Cheney-W Cheney-W added the info:reviewed Pull Request changes follow basic guidelines label May 17, 2023
@JavierMatosD JavierMatosD merged commit aaf629c into microsoft:master May 17, 2023
@MonicaLiu0311 MonicaLiu0311 deleted the Dev/Monica/update_influxdb-cx branch May 18, 2023 05:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[influxdb-cxx] update to v0.7.1
3 participants