Skip to content

"Color selection" off-by-one regression: it colors 1 cell past the end #18739

@jazzdelightsme

Description

@jazzdelightsme

Windows Terminal version

1.23.10732.0

Windows build number

10.0.26388.1001

Other Software

No response

Steps to reproduce

I use the "Color Selection" feature a lot, and often the "all matches" variant, which lets you select some text, and then change the fg/bg color for all occurrences of the selected text.

Recently it started coloring one cell past the end of the selection. In the screenshot below, I selected "abcd", but the colorization applies to "abcde" (as well as "abcdeX", demonstrating that the search is not similarly afected):

Image

Expected Behavior

Just the "abcd" should have been colorized.

Actual Behavior

Colorization included one character past the end.

Metadata

Metadata

Assignees

Labels

Area-TerminalControlIssues pertaining to the terminal control (input, selection, keybindings, mouse interaction, etc.)Issue-BugIt either shouldn't be doing this or needs an investigation.Needs-Tag-FixDoesn't match tag requirementsPriority-3A description (P3)Product-TerminalThe new Windows Terminal.

Type

Projects

Status

Shipped

Relationships

None yet

Development

No branches or pull requests

Issue actions