Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be able to support clicking on embedded links in the mark mode #18310

Open
StevenBucher98 opened this issue Dec 12, 2024 · 1 comment · May be fixed by #18347
Open

Be able to support clicking on embedded links in the mark mode #18310

StevenBucher98 opened this issue Dec 12, 2024 · 1 comment · May be fixed by #18347
Assignees
@carlos-zamora
Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Milestone
Backlog

Comments

@StevenBucher98
Copy link

Description of the new feature

Currently from #13405 support for keyboard use of hyperlinks is supported but does not work for embedded links. For example, when a link is embedded and or does not have the https:// prefix it does not work. Here is a screenshot of scenario where the embedded links are not accessible via keyboard. Image

Proposed technical implementation details

Make embedded links and links that do not have the https:// in the prefix available to be accessed by the mark mode.
@StevenBucher98 StevenBucher98 added the Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. label Dec 12, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Tag-Fix Doesn't match tag requirements Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Dec 12, 2024
@carlos-zamora carlos-zamora self-assigned this Dec 12, 2024
@carlos-zamora carlos-zamora added Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) Product-Terminal The new Windows Terminal. and removed Needs-Tag-Fix Doesn't match tag requirements labels Dec 12, 2024
@carlos-zamora
Copy link
Member

To navigate to a hyperlink using a keyboard (PR #13405)...

  • enter mark mode (ctrl+shift+m)
  • shift+tab or tab to select a hyperlink
  • ctrl+enter to open it

So yeah, we should navigate to the embedded links too

@carlos-zamora carlos-zamora added this to the Backlog milestone Dec 18, 2024
@carlos-zamora carlos-zamora removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Dec 18, 2024
@carlos-zamora carlos-zamora linked a pull request Dec 21, 2024 that will close this issue
Open
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carlos-zamora carlos-zamora

Labels
Area-Interaction Interacting with the vintage console window (as opposed to driving via API or hooks) In-PR This issue has a related PR Issue-Feature Complex enough to require an in depth planning process and actual budgeted, scheduled work. Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Add support for tabbing to embedded hyperlinks microsoft/terminal
2 participants
@carlos-zamora @StevenBucher98