Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an action to copy CWD path to clipboard #12860

Open
Tracked by #13445
zadjii-msft opened this issue Apr 8, 2022 · 3 comments
Open
Tracked by #13445

Add an action to copy CWD path to clipboard #12860

zadjii-msft opened this issue Apr 8, 2022 · 3 comments
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Milestone

Comments

@zadjii-msft
Copy link
Member

I think this is pretty self explanatory.
Similar concerns as the "Open in File Explorer" action, #12859.
Maybe there's a way to make the action do nothing if the active Terminal hasn't set one?

Also relevant: #3337, #5916

@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Apr 8, 2022
@zadjii-msft zadjii-msft added Area-Settings Issues related to settings and customizability, for console or terminal Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. labels Apr 8, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Apr 8, 2022
@zadjii-msft zadjii-msft added this to the Backlog milestone Apr 8, 2022
@zadjii-msft zadjii-msft added Help Wanted We encourage anyone to jump in on these. good first issue This is a fix that might be easier for someone to do as a first contribution labels Apr 8, 2022
@DHowett DHowett removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 8, 2022
@davidegiacometti
Copy link
Contributor

Hi @zadjii-msft
This works as expected with shell configured to update CWD, otherwise the copied path will be the profile starting directory.
Is it fine with the fallback to the starting directory? I Don't think there is an easy way to detect if shell is configured for path integration.

@zadjii-msft
Copy link
Member Author

Is it fine with the fallback to the starting directory

Honestly, yea. If the shell hasn't given us something usable, then let's just go with something rather than nothing at all.

<aside>
A showerthought I had was maybe we flash a TeachingTip with something like "hey you need to set up the shell to tell the Terminal the CWD", but that sounds like a lot of work (and would need a lot more refining). We'd need to track if the path was ever set by the client-side, we'd need to figure out what the messaging is, we'd have to plumb events up to the app layer and back down - that's not worth it.

@davidegiacometti
Copy link
Contributor

Thank you @zadjii-msft for the clarification.
Can you assign this issue to me?

@davidegiacometti davidegiacometti mentioned this issue Jul 17, 2022
6 tasks
@ghost ghost added the In-PR This issue has a related PR label Jul 17, 2022
@ghost ghost removed the In-PR This issue has a related PR label Sep 1, 2022
@zadjii-msft zadjii-msft removed Help Wanted We encourage anyone to jump in on these. good first issue This is a fix that might be easier for someone to do as a first contribution labels Sep 1, 2022
@davidegiacometti davidegiacometti removed their assignment Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Settings Issues related to settings and customizability, for console or terminal Issue-Task It's a feature request, but it doesn't really need a major design. Product-Terminal The new Windows Terminal.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants