Skip to content

Commit 62825ff

Browse files
colinaaaoctogonz
andauthored
[api-extractor] Upgrade bundled TypeScript to 5.7 (#4815)
* WIP: [api-extractor] Upgrade bundled TypeScript to 5.5 1. Upgrade TypeScript to `5.5.2` 2. Upgrade @typescript-eslint/parser to `7.14.1` 3. Adopt breaking changes of typescript-eslint * rush change * Upgrade API Extractor's bundled TypeScript version to 5.7.2 * Update TypeScriptInternals.ts to reflect changes in TypeScript 5.7.2 NOTE: This is a type signature change that didn't affect the runtime contract; it should be fully backwards compatible * rush update * Fix a warning caused by TypeScript 5.7.2 strict checks complaining about resolve() signatures being inconsistent between @types/node/module.d.ts and lib.dom.d.ts: Warning: C:/Git/rushstack/common/temp/default/node_modules/.pnpm/@types[email protected]/node_modules/@types/node/module.d.ts:210:13 - (TS2386) Overload signatures must all be optional or required. * Temporarily suppress warning caused by TypeScript 5.7.2 being incompatible with @types/[email protected]: Warning: C:\Git\rushstack\common\temp\default\node_modules\.pnpm\@types[email protected]\node_modules\@types\node\ts3.2\globals.d.ts:10:11 - (TS2320) Interface 'Buffer' cannot simultaneously extend types 'Uint8Array<ArrayBuffer>' and 'Uint8Array<ArrayBufferLike>'. Named property 'buffer' of types 'Uint8Array<ArrayBuffer>' and 'Uint8Array<ArrayBufferLike>' are not identical. * rush change --------- Co-authored-by: Qingyu Wang <[email protected]> Co-authored-by: Pete Gonzalez <[email protected]>
1 parent d716cce commit 62825ff

File tree

24 files changed

+61
-42
lines changed

24 files changed

+61
-42
lines changed

apps/api-extractor/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@
4949
"resolve": "~1.22.1",
5050
"semver": "~7.5.4",
5151
"source-map": "~0.6.1",
52-
"typescript": "5.4.2"
52+
"typescript": "5.7.2"
5353
},
5454
"devDependencies": {
5555
"@rushstack/heft-node-rig": "2.6.44",

apps/api-extractor/src/analyzer/TypeScriptInternals.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,12 @@ export class TypeScriptInternals {
101101
* Gets the mode required for module resolution required with the addition of Node16/nodenext
102102
*/
103103
public static getModeForUsageLocation(
104-
file: { impliedNodeFormat?: ts.SourceFile['impliedNodeFormat'] },
104+
file: ts.SourceFile,
105105
usage: ts.StringLiteralLike,
106106
compilerOptions: ts.CompilerOptions
107107
): ts.ModuleKind.CommonJS | ts.ModuleKind.ESNext | undefined {
108108
// Compiler internal:
109-
// https://github.com/microsoft/TypeScript/blob/v4.7.2/src/compiler/program.ts#L568
109+
// https://github.com/microsoft/TypeScript/blob/v5.7.2/src/compiler/program.ts#L940
110110

111111
return ts.getModeForUsageLocation?.(file, usage, compilerOptions);
112112
}

apps/api-extractor/src/generators/ApiModelGenerator.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -266,7 +266,7 @@ export class ApiModelGenerator {
266266
}
267267

268268
private _tryFindFunctionDeclaration(astDeclaration: AstDeclaration): ts.FunctionDeclaration | undefined {
269-
const children: ts.Node[] = astDeclaration.declaration.getChildren(
269+
const children: readonly ts.Node[] = astDeclaration.declaration.getChildren(
270270
astDeclaration.declaration.getSourceFile()
271271
);
272272
return children.find(ts.isFunctionTypeNode) as ts.FunctionDeclaration | undefined;

build-tests/api-documenter-scenarios/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"experimentalDecorators": true,
1010
"strictNullChecks": true,
1111
"types": ["node", "jest"],
12-
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable", "dom"],
12+
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable"],
1313
"outDir": "lib"
1414
},
1515
"include": ["src/**/*.ts"]

build-tests/api-extractor-d-cts-test/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"experimentalDecorators": true,
1010
"strictNullChecks": true,
1111
"types": ["node", "jest"],
12-
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable", "dom"],
12+
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable"],
1313
"outDir": "lib"
1414
},
1515
"include": ["src/**/*.cts", "typings/tsd.d.ts"]

build-tests/api-extractor-d-mts-test/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"experimentalDecorators": true,
1010
"strictNullChecks": true,
1111
"types": ["node", "jest"],
12-
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable", "dom"],
12+
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable"],
1313
"outDir": "lib"
1414
},
1515
"include": ["src/**/*.mts", "typings/tsd.d.ts"]

build-tests/api-extractor-lib1-test/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"sourceMap": true,
88
"experimentalDecorators": true,
99
"strictNullChecks": true,
10-
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable", "dom"],
10+
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable"],
1111
"outDir": "lib"
1212
},
1313
"include": ["src/**/*.ts"]

build-tests/api-extractor-lib2-test/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"experimentalDecorators": true,
1010
"strictNullChecks": true,
1111
"types": ["node", "jest"],
12-
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable", "dom"],
12+
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable"],
1313
"outDir": "lib"
1414
},
1515
"include": ["src/**/*.ts", "typings/tsd.d.ts"]

build-tests/api-extractor-lib3-test/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"experimentalDecorators": true,
1010
"strictNullChecks": true,
1111
"types": ["node", "jest"],
12-
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable", "dom"],
12+
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable"],
1313
"outDir": "lib"
1414
},
1515
"include": ["src/**/*.ts", "typings/tsd.d.ts"]

build-tests/api-extractor-lib4-test/tsconfig.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
"experimentalDecorators": true,
1010
"strictNullChecks": true,
1111
"types": ["node", "jest"],
12-
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable", "dom"],
12+
"lib": ["es5", "scripthost", "es2015.collection", "es2015.promise", "es2015.iterable"],
1313
"outDir": "lib"
1414
},
1515
"include": ["src/**/*.ts", "typings/tsd.d.ts"]

0 commit comments

Comments
 (0)