Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make Touchable Text Changes strict-local clean #7149

Open
NickGerleman opened this issue Feb 17, 2021 · 0 comments · May be fixed by #12597
Open

Make Touchable Text Changes strict-local clean #7149

NickGerleman opened this issue Feb 17, 2021 · 0 comments · May be fixed by #12597
Labels
Code Cleanup Deforking enhancement Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Milestone
Backlog

Comments

@NickGerleman
Copy link
Collaborator

facebook/react-native@f275514 increased the strictness used by the Flow type checker in Text.js. Touchable related changes in our version are not clean under new type checker settings.

For now we keep the file using lower strictness.
@ghost ghost added the Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) label Feb 17, 2021
@chrisglein chrisglein added this to the 0.65 milestone Feb 18, 2021
@chrisglein chrisglein added bug and removed Needs: Triage 🔍 New issue that needs to be reviewed by the issue management team (label applied by bot) labels Feb 18, 2021
@rectified95 rectified95 modified the milestones: 0.65, 0.66 Apr 23, 2021
@chrisglein chrisglein modified the milestones: 0.66, 0.67 Aug 31, 2021
@rectified95 rectified95 removed their assignment Jan 7, 2022
@chrisglein chrisglein modified the milestones: 0.67, Backlog Jan 12, 2022
rozele added a commit to rozele/react-native-windows that referenced this issue Jan 12, 2024
@rozele
Remove irrelevant override that eliminated strict-local
488f1de 
It seems this change was needed when Text.windows.js was imported at one
point or another, but yarn lint is clean now when reverting the @flow
settings to strict-local.

Ran yarn lint to test.

Resolves microsoft#7149
@rozele rozele linked a pull request Jan 12, 2024 that will close this issue
Draft
rozele added a commit to rozele/react-native-windows that referenced this issue Jan 12, 2024
@rozele
Remove irrelevant override that eliminated strict-local
a5e60ae 
It seems this change was needed when Text.windows.js was imported at one
point or another, but yarn lint is clean now when reverting the @flow
settings to strict-local.

Ran yarn lint to test.

Resolves microsoft#7149
@chiaramooney chiaramooney added the Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs. label Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Code Cleanup Deforking enhancement Workstream: Component Parity Close the parity gap between RNW and RN for core RN components and their supporting APIs.
Projects
None yet
Milestone
Backlog
Development

Successfully merging a pull request may close this issue.

Remove irrelevant override that eliminated strict-local rozele/react-native-windows
5 participants
@NickGerleman @jonthysell @rectified95 @chrisglein @chiaramooney