Skip to content

Commit 0ec2ef7

Browse files
Nitin ChaudharyNitin-100
authored andcommitted
Fix OInstance.cpp: Use m_devSettings instead of devSettings parameter
Address PR review comment from @anupriya13: - Changed 'devSettings' to 'm_devSettings' in bundle path validation error callback - This ensures we're using the member variable consistently throughout the class - devSettings parameter is not in scope at this point in the function
1 parent 4335777 commit 0ec2ef7

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

vnext/Shared/OInstance.cpp

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -97,8 +97,8 @@ void LoadRemoteUrlScript(
9797
try {
9898
Microsoft::ReactNative::InputValidation::PathValidator::ValidateFilePath(jsBundleRelativePath, "");
9999
} catch (const Microsoft::ReactNative::InputValidation::ValidationException &ex) {
100-
if (devSettings && devSettings->errorCallback) {
101-
devSettings->errorCallback(std::string("Bundle path validation failed: ") + ex.what());
100+
if (m_devSettings && m_devSettings->errorCallback) {
101+
m_devSettings->errorCallback(std::string("Bundle path validation failed: ") + ex.what());
102102
}
103103
return;
104104
}

0 commit comments

Comments
 (0)