-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NativeModuleSample based on cpp-lib
template
#991
Conversation
cpp-lib
templatecpp-lib
template
Note: I will update our native module documentation and delete the old sample in separate PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick question: why don't we add the RnwNewArch
constants to the old arch templates with the value set to false
? Do we want the main upgrade path to be just running the new templates?
Yes, the intent for the new library templates (currently just If the value isn't set (aka every project not 0.76.0+'s While the library does appear to set it to true in it's But in this new world where (new) libraries come with a ready to use example app, it's actually a better experience to build the example app so you can actually test that your native module works. And therefore in this example we have two example apps, so you can test both new and old architectures. |
Description
This PR intends to replace the existing sample at
NativeModuleSample\cppwinrt
with a newNativeModuleSample\cpp-lib
, based on thecpp-lib
template exposed in RNW 0.76.0.Features of this new sample includes:
Why
The old sample is based on the Old Architecture, UWP-based C++ library template. That template is not the target of active development, while the new template is the new standard for RNW >= 0.76.0.
Screenshots
Microsoft Reviewers: Open in CodeFlow