Adding linting to qsc_formatter and fixing the warnings #2339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves issue #2276.
There were several straightforward lints that made perfect sense to fix (e.g. adding the must_use and the backticks).
But there were a few that I wasn't sure about:
apply_rules, it's because I think the method is more readable as a very long function, especially given that it's the match statement that's taking up most of the lines.apply_rules. My opinion is that completely fixing the branches ends up going from many straightforward conditions to less (but still many) complicated conditions. So I fixed some of the arms but then disabled the lint for the rest. If you want, I can fix the rest of the arms instead.&TokenKindand&KeywordtoTokenKindorKeyword.