Skip to content

Evaluator produces confusing locals view while debugging #1436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
swernli opened this issue Apr 26, 2024 · 0 comments · Fixed by #1442
Closed

Evaluator produces confusing locals view while debugging #1436

swernli opened this issue Apr 26, 2024 · 0 comments · Fixed by #1442
Assignees
Labels
bug Something isn't working

Comments

@swernli
Copy link
Collaborator

swernli commented Apr 26, 2024

The evaluator refactoring in #1261 had an unexpected side effect of leaving variables in scope too long, which can cause confusing debugger output:
image
The y: 1 entry should only be visible while inside the block for the if-expression. The control flow graph will need to be updated to include scope entry and exit markers when running in debug mode.

@swernli swernli added bug Something isn't working needs triage labels Apr 26, 2024
@swernli swernli self-assigned this Apr 26, 2024
swernli added a commit that referenced this issue Apr 29, 2024
This adds new execution graph nodes for pushing and popping variable scopes that are used only while debugging (like statement nodes) so that the evaluator can correctly respond to local variable requests during debugging.

Fixes #1436
github-merge-queue bot pushed a commit that referenced this issue Apr 29, 2024
This adds new execution graph nodes for pushing and popping variable
scopes that are used only while debugging (like statement nodes) so that
the evaluator can correctly respond to local variable requests during
debugging.

Fixes #1436
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant