-
Notifications
You must be signed in to change notification settings - Fork 840
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix tool calls parsing for definitions containing arrays #3389
Closed
bwilliams2
wants to merge
13
commits into
microsoft:main
from
bwilliams2:bwilliams2/tool_calls_parsing
Closed
Fix tool calls parsing for definitions containing arrays #3389
bwilliams2
wants to merge
13
commits into
microsoft:main
from
bwilliams2:bwilliams2/tool_calls_parsing
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Makes a small change to the parsing for tool_calls within Jinja templates. Previously square bracket pairs defined matching group which caused incomplete matching when square brackets were used within the tool_calls definition (e.g., arguments with arrays for function calls). This PR changes the matching logic to match the tool_call preamble definitions and removes then removes the matching preamble from the prompt. This avoids the need for more complex recursive bracket matching.
The bug was fixed in the two identical functions defined in
promptflow-tools/promptflow/tools/common.py
andpromptflow-core/core/_prompty_utils.py
. Test case added topromptflow-tools
but I did not find existing test cases for the relevant code inpromptflow-core
. If directed to the right location, I can added additional test cases there.Fixes #3388
All Promptflow Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines