Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feedback]: Experimental ssim-cie94 comparator #32057

Open
samschurter opened this issue Aug 7, 2024 · 1 comment
Open

[Feedback]: Experimental ssim-cie94 comparator #32057

samschurter opened this issue Aug 7, 2024 · 1 comment

Comments

@samschurter
Copy link

Version

1.45.3

Steps to reproduce

  1. Use the test to take a screenshot of a page with an image locally using the headful browser using the experimental {_comparator: 'ssim-cie94'} configuration.
  2. Run the same test in CI using the headless=new flag when launching the browser
  3. Observe that the screenshot comparison fails
  4. Adjust the threshold setting to be more permissive and run again
  5. Observe that the comparison still fails with the same diff.
  6. Swap the comparator for the default pixelmatch and run the test again
  7. Observe that the diff is already much more lenient about small color changes.

Expected behavior

The ssim-cie94 should be more resilient to differences between rendering engines, even when not comparing text, or should have configuration options for extra lenience when required.

Actual behavior

ssim-cie94 results in worse matches than pixelmatch in some circumstances.

Additional context

This isn't really a bug report as I don't think there is any actual bug, just feedback on the ssim-cie94 comparator as requested in a couple issues.
Reproduction: https://github.com/samschurter/playwright-threshold-bug

Environment

System:
    OS: macOS 14.5
    CPU: (12) arm64 Apple M3 Pro
    Memory: 7.15 GB / 36.00 GB
  Binaries:
    Node: 22.5.1 - ~/.nvm/versions/node/v22.5.1/bin/node
    npm: 10.8.2 - ~/.nvm/versions/node/v22.5.1/bin/npm
  IDEs:
    VSCode: 1.92.0 - /Applications/Visual Studio Code.app/Contents/Resources/app/bin/code
  Languages:
    Bash: 3.2.57 - /bin/bash

GitHub Actions CI environment:
- Ubuntu 22.04
- 4 amd64 vCPUs
- Node 20
@yury-s
Copy link
Member

yury-s commented Aug 8, 2024

Thanks for the feedback!

Related issue: #24312

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants