Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] playwright 1.40.0 is strictly depend on pyee==11.0.1 #2190

Open
vzhirnov opened this issue Dec 11, 2023 · 4 comments
Open

[BUG] playwright 1.40.0 is strictly depend on pyee==11.0.1 #2190

vzhirnov opened this issue Dec 11, 2023 · 4 comments

Comments

@vzhirnov
Copy link

vzhirnov commented Dec 11, 2023

System info

  • Playwright Version: 1.40.0

  • Operating System: macos monterey 12.2.1
    (Apple M1)

  • Other info:

pyee==11.0.1

Steps
Try to update pyee from version 11.0.1 to 11.1.0

Expected

update pyee from version 11.0.1 to 11.1.0 is completed successfully.

Actual

We cannot install new pyee version, because

The conflict is caused by:
    The user requested pyee==11.1.0
    playwright 1.40.0 depends on pyee==11.0.1

Is that the correct behaviour? Do we need use pyee with only 11.0.1 version and not above?

@vzhirnov
Copy link
Author

The issue is updated. I'm sorry, I initially specified the wrong version of the operating system.

@RazerM
Copy link
Contributor

RazerM commented Dec 13, 2023

This is a general issue I'm facing too where greenlet is also pinned. This seems needlessly restrictive.

The commits that bump pyee and greenlet have no code changes, so there doesn't seem to be a compatibility reason (and even then, ranges like 'greenlet>=3.0.0,<4,!=3.0.1' would be better)

@christopher-watanabe-snkeos

On a related note, I recently noticed failing tests due to AsyncIOEventEmitter deprecation in pyee v12.0.0. I was using a the much older v1.13.1 playwright and was not pinning the dependencies.

I updated and pinned the versions as follows:
playwright == 1.47.0
pyee == 12.0.0
greenlet == 3.0.3

And my tests ran as expected.

@mborsetti
Copy link

Any chance you can stop pinning so we don't have to live in dependency (and installation) hell?

Also see #2564 for more pinning woes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants