New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove pypgstac from pcstac requirements #31

Open

vincentsarago opened this issue Jan 14, 2022 · 0 comments

Labels

bug

Contributor

vincentsarago commented Jan 14, 2022

previously raised in #25

Right now pypgstac is added to pcstac requirements but only really useful in testing. It's also use to

run migration: this could be replaced by using pgstac official docker image
wait for the db to be up (pypgstac ready) https://github.com/microsoft/planetary-computer-apis/blob/main/docker-compose.yml#L40 which could be replaced with a simple bash script (e.g https://github.com/stac-utils/stac-fastapi/blob/master/scripts/wait-for-it.sh)

ps: I've done it in a previous (closed) PR: developmentseed#1

vincentsarago added the bug label

vincentsarago mentioned this issue

Do not alter database entries when running tests #32

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment