Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented Conv2D, Depth2Space, and Resize. Is anyone interested in merging these changes back? #23471

Open
linzj opened this issue Jan 23, 2025 · 7 comments
Labels
contributions welcome external contributions welcome ep:WebGPU ort-web webgpu provider

Comments

@linzj
Copy link

linzj commented Jan 23, 2025

Describe the issue

I have partially implemented Conv2D, Depth2Space, and Resize, not fully tested. These implementations have been tested on an Android device and are running my model without issues. What should be the next steps? Is anyone interested in collaborating to improve these implementations and eventually merge them into the main branch?
My fork is https://github.com/linzj/onnxruntime, branch is feature/ops-svr.

To reproduce

No content.

Urgency

No response

Platform

Android

OS Version

15

ONNX Runtime Installation

Built from Source

ONNX Runtime Version or Commit ID

afd3e81

ONNX Runtime API

C++

Architecture

ARM64

Execution Provider

Other / Unknown

Execution Provider Library Version

No response

@github-actions github-actions bot added the platform:mobile issues related to ONNX Runtime mobile; typically submitted using template label Jan 23, 2025
@snnn snnn added the contributions welcome external contributions welcome label Jan 24, 2025
@snnn
Copy link
Member

snnn commented Jan 24, 2025

Welcome to submit PRs to us.

@linzj
Copy link
Author

linzj commented Jan 25, 2025

Welcome to submit PRs to us.

Thanks for the feedback! Should I complete the full implementation of the Conv operator (including all functionalities and test cases) before submitting a PR, or would you prefer an early review of the current partial implementation?

@snnn
Copy link
Member

snnn commented Jan 25, 2025

Is it for webgpu ?

@linzj
Copy link
Author

linzj commented Jan 25, 2025

Is it for webgpu ?

yes.

@snnn snnn added ep:WebGPU ort-web webgpu provider and removed platform:mobile issues related to ONNX Runtime mobile; typically submitted using template labels Jan 27, 2025
@xhcao
Copy link
Contributor

xhcao commented Feb 21, 2025

Hi, @linzj There was an conflict that I had already implemented the resize operator on webgpu backend. #23780
Sorry for the conflict, and I took this task before the Chinese Spring Festival, you could review my code if possible, thanks.

@linzj
Copy link
Author

linzj commented Feb 21, 2025 via email

@linzj
Copy link
Author

linzj commented Feb 21, 2025

Oh. I noted that you disabled the nhwc support. That's unexpected. Check mine version please. Mine has the nhwc supported. We must support nhwc to make conv2d vectorization available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contributions welcome external contributions welcome ep:WebGPU ort-web webgpu provider
Projects
None yet
Development

No branches or pull requests

3 participants