Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OIDC] Make API Authorization(resource) optional #1664

Open
nakamume opened this issue Apr 19, 2021 · 0 comments
Open

[OIDC] Make API Authorization(resource) optional #1664

nakamume opened this issue Apr 19, 2021 · 0 comments
Assignees
@audrieMSFT
Labels
Issue type - enhancement request New feature being requested outside of original scope. Plugin - auth_oidc

Comments

@nakamume
Copy link

nakamume commented Apr 19, 2021 •
edited
Loading

The OIDC plugin sends resource request for api authorization. The request is sent to https://graph.microsoft.com by default.

Screen Shot 2021-04-19 at 9 52 42

We use OIDC plugin just for authentication and not for any API authorization. In current state our IdP integration will always fail with
Error in OpenID Connect: unauthorized ‘resource’ requested

Could we make Resource param null by default.

I'll open a PR for this

Edit: Opened a PR microsoft/moodle-auth_oidc#48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@audrieMSFT audrieMSFT

Labels
Issue type - enhancement request New feature being requested outside of original scope. Plugin - auth_oidc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weilai-irl @nakamume @audrieMSFT