Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NULL Check as IpmiSendCommandInternal does not consider NULL parameter for ResponseData and ResponseDataSize Parameter #242

Open
1 task done
anandakrishnanl opened this issue Jun 28, 2024 · 0 comments
Open
1 task done

Add NULL Check as IpmiSendCommandInternal does not consider NULL parameter for ResponseData and ResponseDataSize Parameter #242

anandakrishnanl opened this issue Jun 28, 2024 · 0 comments
Labels
state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:medium Important with a moderate impact

Comments

@anandakrishnanl
Copy link

Is there an existing issue for this?

  • I have searched existing issues

Current Behavior

IpmiSendCommandInternal does not consider NULL parameter for ResponseData and ResponseDataSize Parameter

Expected Behavior

NULL can be passed as parameter for

IN OUT UINT8 *ResponseData,
IN OUT UINT8 *ResponseDataSize

in IpmiSendCommandInternal Routine

Steps To Reproduce

Pass NULL for any IPMI send Command which will result in Exception

Build Environment

Windows 11
VS2019
NA

Version Information

https://azurecsi.visualstudio.com/MCUP/_git/Common/commit/d5fc34607f80751eba6d3d6a8dec86305ef0c228?refName=refs/heads/main

Urgency

Medium

Are you going to fix this?

I will fix it

Do you need maintainer feedback?

Maintainer feedback requested

Anything else?

NULL Check Fix will be pushed to a branch and pull request will be created
@anandakrishnanl anandakrishnanl added state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working labels Jun 28, 2024
@github-actions github-actions bot added state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps urgency:medium Important with a moderate impact labels Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
state:needs-maintainer-feedback Needs more information from a maintainer to determine next steps state:needs-triage Needs to triaged to determine next steps type:bug Something isn't working urgency:medium Important with a moderate impact
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@anandakrishnanl