Error generating CSharp Client: The type does not contain any information #6087
Comments
magahl
added
status:waiting-for-triage
|
Thanks for raising this @magahl I suspect that the error here is caused by the base schema being empty (only has a title and type and isn't really expected), so when the generator goes up the hierarchy and finds this empty schema. Out of curiosity, when you make the code change, do you get a class called |
andrueastman
added
status:waiting-for-author-feedback
|
Yes I do get a class: // <auto-generated/>
#pragma warning disable CS0618
using Microsoft.Kiota.Abstractions.Extensions;
using Microsoft.Kiota.Abstractions.Serialization;
using System.Collections.Generic;
using System.IO;
using System;
namespace Swegon.Crm.Dynamics.Models
{
[global::System.CodeDom.Compiler.GeneratedCode("Kiota", "1.0.0")]
#pragma warning disable CS1591
public partial class Crmbaseentity : IAdditionalDataHolder, IParsable
#pragma warning restore CS1591
{
/// <summary>Stores additional data not described in the OpenAPI description found when deserializing. Can be used for serialization as well.</summary>
public IDictionary<string, object> AdditionalData { get; set; }
/// <summary>
/// Instantiates a new <see cref="global::Swegon.Crm.Dynamics.Models.Crmbaseentity"/> and sets the default values.
/// </summary>
public Crmbaseentity()
{
AdditionalData = new Dictionary<string, object>();
}
/// <summary>
/// Creates a new instance of the appropriate class based on discriminator value
/// </summary>
/// <returns>A <see cref="global::Swegon.Crm.Dynamics.Models.Crmbaseentity"/></returns>
/// <param name="parseNode">The parse node to use to read the discriminator value and create the object</param>
public static global::Swegon.Crm.Dynamics.Models.Crmbaseentity CreateFromDiscriminatorValue(IParseNode parseNode)
{
_ = parseNode ?? throw new ArgumentNullException(nameof(parseNode));
return new global::Swegon.Crm.Dynamics.Models.Crmbaseentity();
}
/// <summary>
/// The deserialization information for the current model
/// </summary>
/// <returns>A IDictionary<string, Action<IParseNode>></returns>
public virtual IDictionary<string, Action<IParseNode>> GetFieldDeserializers()
{
return new Dictionary<string, Action<IParseNode>>
{
};
}
/// <summary>
/// Serializes information the current object
/// </summary>
/// <param name="writer">Serialization writer to use to serialize this model</param>
public virtual void Serialize(ISerializationWriter writer)
{
_ = writer ?? throw new ArgumentNullException(nameof(writer));
writer.WriteAdditionalData(AdditionalData);
}
}
}
#pragma warning restore CS0618 |
microsoft-github-policy-service
bot
added
Needs: Attention 👋
and removed
status:waiting-for-author-feedback
|
Thanks for the feedback here @magahl @baywet Any chance you'd have some thoughts on whether it's useful to prevent the generation of "meaningless" schemas as seen in this scenario? Arguably, as we go up the hierarchy, Kiota could try to remove/ignore the schema in the inheritance hierarchy once it's clear that the base is meaningless rather than failing. |
|
On removing the first entry in the AllOf for the |
|
One reason why we ignore "meaningless" schemas is because a lot of the tooling that does automatic OAS description generation from an object model produces waste with empty schemas which end up derailing kiota, or lead to a poor experience once the client is generated. Now, one could argue that an empty type is meaningful when it's part of a type hierarchy and has a name... it's a trade off. Let me know if you have any additional comments or questions. |
|
The type comes from ”your” own system Dynamics365. It’s not something we really wanted. But it’s there. |
|
Thank you for the additional information. As you can imagine, Microsoft is a huge organization and sometimes misalignments happen. @andrueastman what would you think of emitting the type, with the grand parent as the parent instead (if any) and emitting a warning instead of failing? |
What are you generating using Kiota, clients or plugins?
API Client/SDK
In what context or format are you using Kiota?
Nuget tool
Client library/SDK language
Csharp
Describe the bug
First off. I dont really know if this is a bug or not. Or if this is just not supported or a invalid schema.
But i have taken the edmx from our Dynamics 365 instance and trimmed the schema down to only include one property. After that i use Microsoft.OpenApi.OData to generate a json schema from that file. The schema seems valid when i try it on https://editor-next.swagger.io/
But when i run:
kiota generate -d c:/temp/d365_min.json -l csharp -n Dynamics -c D365Client -o c:/temp/D365/Generated --ll debugI get an exception beacuse of an (what i believe empty type)
Expected behavior
Successfull client generation.
How to reproduce
kiota generate -d c:/temp/d365_min.json -l csharp -n Dynamics -c D365Client -o c:/temp/D365/Generated --ll debugOpen API description file
d365_min.json
Kiota Version
1.22.3+a544276a5ee9d4a7b67cc0fbd5ce2804c172fa14
Latest Kiota version known to work for scenario above?(Not required)
No response
Known Workarounds
I did run this in latest main of your repo as well.
and if i replace
throw new InvalidOperationException($"The type does not contain any information Path: {currentNode.Path}, Reference Id: {referenceId}"),at line KiotaBuilder:1774 with
AddModelDeclarationIfDoesntExist(currentNode, operation, schema, className, shortestNamespace)It seems to work, but I'm not sure what I'm doing here 😅
Configuration
Windows 11 24H2
x64
Debug output
Click to expand log
``` ```Other information
No response
The text was updated successfully, but these errors were encountered: