Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Failining integration tests on apisguru::docsusing.net #5744

Closed
shemogumbe opened this issue Nov 9, 2024 · 1 comment · Fixed by #5729
Closed

Failining integration tests on apisguru::docsusing.net #5744

shemogumbe opened this issue Nov 9, 2024 · 1 comment · Fixed by #5729
Assignees
@andrueastman
Labels
WIP

Comments

@shemogumbe
Copy link
Contributor

Following this fix #5616

Raised on:
#5417

We have a failing integration test on https://github.com/microsoft/kiota/actions/runs/11755263098/job/32750170882?pr=5724

By design, the passed parameter should be of type str and not "str"

https://github.com/microsoft/kiota-python/blob/main/packages/abstractions/kiota_abstractions/request_adapter.py#L102
@shemogumbe shemogumbe added the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Nov 9, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Nov 9, 2024
@andrueastman
Copy link
Member

This should be resolved with the fixes made in #5729

@andrueastman andrueastman removed the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Nov 11, 2024
@andrueastman andrueastman self-assigned this Nov 11, 2024
@andrueastman andrueastman moved this from Needs Triage 🔍 to Todo 📃 in Kiota Nov 11, 2024
@andrueastman andrueastman moved this from Todo 📃 to In Progress 🚧 in Kiota Nov 11, 2024
@andrueastman andrueastman mentioned this issue Nov 11, 2024
Merged
@andrueastman andrueastman moved this from In Progress 🚧 to In Review 💭 in Kiota Nov 12, 2024
@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Kiota Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrueastman andrueastman

Labels
WIP
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes python generation with comment opening/closing tags microsoft/kiota
2 participants
@andrueastman @shemogumbe