Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Python Generation adds imports of classes not Used in the Modules #5667

Closed
1 of 3 tasks
shemogumbe opened this issue Oct 24, 2024 · 4 comments
Closed
1 of 3 tasks

Python Generation adds imports of classes not Used in the Modules #5667

shemogumbe opened this issue Oct 24, 2024 · 4 comments
Assignees
@shemogumbe
Labels
type:investigation Investigation work, output should be a document detailing findings or a prototype

Comments

@shemogumbe
Copy link
Contributor

shemogumbe commented Oct 24, 2024 •
edited
Loading

Following this generation https://github.com/microsoftgraph/msgraph-sdk-python/pull/938/files

The generator seems to have added imports to come inline classes that are however not used in the mmodules

  • Investigate what caused the imports to be generated
  • Check if the imports are needed
  • If needed, document, if not, revert the change that introduced them
@shemogumbe shemogumbe added the status:waiting-for-triage An issue that is yet to be reviewed or assigned label Oct 24, 2024
@shemogumbe shemogumbe self-assigned this Oct 24, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Oct 24, 2024
@shemogumbe shemogumbe moved this from Needs Triage 🔍 to Todo 📃 in Kiota Oct 24, 2024
@shemogumbe shemogumbe added type:investigation Investigation work, output should be a document detailing findings or a prototype and removed status:waiting-for-triage An issue that is yet to be reviewed or assigned labels Oct 24, 2024
@andrueastman
Copy link
Member

This could possibly be related to #5637

@shemogumbe
Copy link
Contributor Author

The imports in the serialize class are not needed there are they are already imported at the top of the module.

@shemogumbe
Copy link
Contributor Author

Fixed by #5724

@shemogumbe shemogumbe moved this from Todo 📃 to In Review 💭 in Kiota Nov 4, 2024
@Ndiritu
Copy link
Contributor

Ndiritu commented Nov 21, 2024

closed in linked PR

@Ndiritu Ndiritu closed this as completed Nov 21, 2024
@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Kiota Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shemogumbe shemogumbe

Labels
type:investigation Investigation work, output should be a document detailing findings or a prototype
Projects
Kiota
Status: Done ✔️
Milestone
No milestone
Development

No branches or pull requests
3 participants
@andrueastman @Ndiritu @shemogumbe