Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kiota client generate --refresh command leads to the serialization registration to be added #5431

Closed
baywet opened this issue Sep 17, 2024 · 2 comments · Fixed by #5478
Closed

kiota client generate --refresh command leads to the serialization registration to be added #5431

baywet opened this issue Sep 17, 2024 · 2 comments · Fixed by #5478
Assignees
@andrueastman @timayabi2020
Labels
generator Issues or improvements relater to generation capabilities. priority:p1 High priority/Major issue but not blocking or Big percentage of customers affected.Bug SLA <=7days type:bug A broken experience WIP
Milestone
Kiota v1.19

Comments

@baywet
Copy link
Member

baywet commented Sep 17, 2024

  1. generate a client with the workspace experience in the CLI
  2. run kiota client generate --refresh

Note that serialization registration is added to the client constructor when it shouldn't.
This is probably being caused by the value being defaulted, which should be set to "none" in that configuration.
@baywet baywet added type:bug A broken experience generator Issues or improvements relater to generation capabilities. priority:p1 High priority/Major issue but not blocking or Big percentage of customers affected.Bug SLA <=7days labels Sep 17, 2024
@baywet baywet added this to the Kiota v1.18.1 milestone Sep 17, 2024
@baywet baywet added this to Kiota Sep 17, 2024
@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Sep 17, 2024
@baywet baywet moved this from Needs Triage 🔍 to Todo 📃 in Kiota Sep 17, 2024
@sebastienlevert sebastienlevert moved this from Todo 📃 to Needs Triage 🔍 in Kiota Sep 23, 2024
@andrueastman andrueastman moved this from Needs Triage 🔍 to Todo 📃 in Kiota Sep 25, 2024
@andrueastman
Copy link
Member

The culprit here is probably this function that needs to be dropped as we now have bundle packages rolling out.

kiota/src/kiota/Handlers/BaseKiotaCommandHandler.cs

Line 16 in e9ec0fa

protected static void DefaultSerializersAndDeserializers(GenerationConfiguration generationConfiguration)

For context, these lines are what should be excluded when running the command.
https://github.com/microsoft/kiota-samples/blob/main/msgraph-mail/dotnet/ApiClient.cs#L32-L38

@baywet
Copy link
Member Author

baywet commented Sep 25, 2024

Dropped I don't think so since we still need to support the older commands. But only executed for the non workspace experience yes.

@timayabi2020 timayabi2020 linked a pull request Sep 26, 2024 that will close this issue
Removes registration of default serialization and deserialization classes from the Api client constructor. #5478
Merged
@timayabi2020 timayabi2020 mentioned this issue Sep 26, 2024
Merged
@timayabi2020 timayabi2020 moved this from Todo 📃 to In Review 💭 in Kiota Sep 26, 2024
@github-project-automation github-project-automation bot moved this from In Review 💭 to Done ✔️ in Kiota Sep 26, 2024
@baywet baywet modified the milestones: Kiota v1.18.1, Kiota v1.19 Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andrueastman andrueastman

@timayabi2020 timayabi2020

Labels
generator Issues or improvements relater to generation capabilities. priority:p1 High priority/Major issue but not blocking or Big percentage of customers affected.Bug SLA <=7days type:bug A broken experience WIP
Projects
Kiota
Archived in project
Milestone
Kiota v1.19
3 participants
@andrueastman @baywet @timayabi2020