Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Circular references in open API spec are not supported #5381

Closed
Tracked by #5162
calebkiage opened this issue Sep 10, 2024 · 7 comments
Closed
Tracked by #5162

Circular references in open API spec are not supported #5381

calebkiage opened this issue Sep 10, 2024 · 7 comments
Assignees
Labels
blocked This work can't be done until an external dependent work is done.

Comments

@calebkiage
Copy link
Contributor

No description provided.

@github-project-automation github-project-automation bot moved this to Needs Triage 🔍 in Kiota Sep 10, 2024
@petrhollayms
Copy link
Contributor

#5162 (comment)

Thanks @darrelmiller , so suggesting we keep it for post-GA and re-evaluate later on based on the feedback from users.

@baywet
Copy link
Member

baywet commented Sep 10, 2024

I'm guessing this is specific to plugins generation right?

@calebkiage
Copy link
Contributor Author

@baywet, right. The parent issue has a list of unsupported scenarios that need handling

@maisarissi
Copy link
Contributor

The circular reference might be fixed by SK team when SK supports nested objects that contain parameters that have the same property names.

@maisarissi maisarissi moved this from Todo 📃 to Blocked 🔒 in Kiota Nov 5, 2024
@baywet
Copy link
Member

baywet commented Nov 10, 2024

So should we close this issue since there's no action to be taken on kiota's side then @maisarissi ?

@petrhollayms
Copy link
Contributor

@maisarissi Are we good to close this issue as "won't do"?

@maisarissi
Copy link
Contributor

Yes. This will be done and validated in the manifest library. Closing this one.

@github-project-automation github-project-automation bot moved this from Blocked 🔒 to Done ✔️ in Kiota Nov 12, 2024
@baywet baywet closed this as not planned Won't fix, can't repro, duplicate, stale Nov 13, 2024
@calebkiage calebkiage moved this from Done ✔️ to Closed ⛔ in Kiota Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked This work can't be done until an external dependent work is done.
Projects
Status: Closed ⛔
Development

No branches or pull requests

4 participants