Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-deterministic Go compilation failures with AdditionalDataHolder and Parsable #3700

Closed
kfcampbell opened this issue Nov 13, 2023 · 4 comments
Labels
Go status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close type:bug A broken experience
Milestone

Comments

@kfcampbell
Copy link
Member

See octokit/source-generator#28.

When using GitHub's OpenAPI spec, generation of Go code will succeed but compilation will frequently fail due to the following error:

in the file generated/go/users/item_starred_repository.go, Kiota occasionally generates a file that includes

// ItemStarredRepositoryable
type ItemStarredRepositoryable interface {
    IAdditionalDataHolder
}

when it otherwise generates (correctly)

// ItemStarredRepositoryable
type ItemStarredRepositoryable interface {
    i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.AdditionalDataHolder
    i878a80d2330e89d26896388a3f487eef27b0a0e6c010c493bf80be1452208f91.Parsable
}

@baywet helped triage this issue and recommended setting KIOTA_GENERATION_MAXDEGREEOFPARALLELISM to 0, after which the issue occurs less frequently but still occurs. This is using Kiota 1.8.1.

Please let me know if more information is needed!

@andreaTP
Copy link
Contributor

andreaTP commented Jan 5, 2024

The issue should be reproducible in CI by adding an entry here, unfortunately testing locally I encounter other errors with Go.

@baywet baywet modified the milestones: Kiota v1.10, Kiota v1.11 Jan 11, 2024
@baywet baywet modified the milestones: Kiota v1.11, Kiota v1.12 Jan 30, 2024
@baywet baywet modified the milestones: Kiota v1.12, Kiota v1.13 Mar 4, 2024
@sebastienlevert sebastienlevert modified the milestones: Kiota v1.13, Backlog Mar 27, 2024
@sebastienlevert sebastienlevert moved this from Todo 📃 to In Review 💭 in Kiota May 9, 2024
@rkodev
Copy link
Contributor

rkodev commented May 9, 2024

Hi @kfcampbell are you still running into this issue with kiota v1.14.*?

Copy link
Contributor

This issue has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 4 days. It will be closed if no further activity occurs within 3 days of this comment.

@fey101 fey101 added status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close and removed Needs: Author Feedback labels May 16, 2024
@kfcampbell
Copy link
Member Author

Hey sorry, I was delayed testing this due to #4690 and #4691. I've worked around those issues for the time being and been unable to reproduce this issue, so I think it's okay to close. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go status:waiting-for-author-feedback Issue that we've responded but needs author feedback to close type:bug A broken experience
Projects
Archived in project
Development

No branches or pull requests

6 participants