-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.5.0 Generates broken Go request builder #3090
Comments
I assume this is building with Graph APIs? Why are we building with Kiota in our Quick Starts? @baywet are we testing against Graph on Kiota? I feel we should at least validate that the Graph surface goes through, especially as we will be asking teams to lock their versions so it means we could introduce changes that could break Graph. |
@sebastienlevert all ids are strings in Microsoft Graph, so this defect doesn't manifest for Microsoft Graph. And to answer your broader question, no Microsoft Graph is not included in our integration tests for the time being the reasoning being: we already have weekly generations to catch those issues for Microsoft Graph (when they apply). |
pushed a few changes to #3091 to address this |
Ok I thought the quickstart failing was the Graph one, not the Kiota one. Shall this be a patch? I feel a bug fix like this one should reach devs ASAP? |
We can release a patch once this gets merged. Since everybody else is poor in the fire kiota's team, I'll rely on you to make the final decision. |
The fact our docs fail because of an update is a good indicator we need to ship a patch version. Also, I think we should include the docs OpenAPI descriptions we use to limit these cases in the future. |
alright, updated my PR to prepare for a patch version. It'll also contain python backing store support but I don't think that's and issue. |
Using our quickstart:
Offending code:
The text was updated successfully, but these errors were encountered: