Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.5.0 Generates broken Go request builder #3090

Closed
jasonjoh opened this issue Aug 8, 2023 · 7 comments · Fixed by #3091
Closed

1.5.0 Generates broken Go request builder #3090

jasonjoh opened this issue Aug 8, 2023 · 7 comments · Fixed by #3091
Assignees
Labels
Go type:bug A broken experience WIP
Milestone

Comments

@jasonjoh
Copy link
Member

jasonjoh commented Aug 8, 2023

Using our quickstart:

$ go build -v ./...
kiota_posts/client/posts
# kiota_posts/client/posts
client/posts/posts_request_builder.go:54:18: invalid operation: postId != nil (mismatched types int32 and untyped nil)
client/posts/posts_request_builder.go:55:37: undefined: i53ac87e8cb3cc9276228f74d38694a208cacb99bb8ceb705eeae99fb88d4d274
client/posts/posts_request_builder.go:55:120: invalid operation: cannot indirect postId (variable of type int32)

Offending code:

if postId != nil {
    urlTplParams["post%2Did"] = i53ac87e8cb3cc9276228f74d38694a208cacb99bb8ceb705eeae99fb88d4d274.FormatInt(int64(*postId), 10)
}
@sebastienlevert
Copy link
Contributor

I assume this is building with Graph APIs? Why are we building with Kiota in our Quick Starts?

@baywet are we testing against Graph on Kiota? I feel we should at least validate that the Graph surface goes through, especially as we will be asking teams to lock their versions so it means we could introduce changes that could break Graph.

@baywet baywet self-assigned this Aug 8, 2023
@baywet baywet added type:bug A broken experience Go labels Aug 8, 2023
@baywet baywet added this to Kiota Aug 8, 2023
@baywet baywet moved this to Todo in Kiota Aug 8, 2023
@baywet baywet added this to the Kiota v1.6 milestone Aug 8, 2023
@baywet
Copy link
Member

baywet commented Aug 8, 2023

@sebastienlevert all ids are strings in Microsoft Graph, so this defect doesn't manifest for Microsoft Graph. And to answer your broader question, no Microsoft Graph is not included in our integration tests for the time being the reasoning being: we already have weekly generations to catch those issues for Microsoft Graph (when they apply).

@baywet
Copy link
Member

baywet commented Aug 8, 2023

pushed a few changes to #3091 to address this

@baywet baywet moved this from Todo to In Progress in Kiota Aug 8, 2023
@sebastienlevert
Copy link
Contributor

sebastienlevert commented Aug 8, 2023

Ok I thought the quickstart failing was the Graph one, not the Kiota one. Shall this be a patch? I feel a bug fix like this one should reach devs ASAP?

@baywet
Copy link
Member

baywet commented Aug 8, 2023

We can release a patch once this gets merged. Since everybody else is poor in the fire kiota's team, I'll rely on you to make the final decision.

@sebastienlevert
Copy link
Contributor

The fact our docs fail because of an update is a good indicator we need to ship a patch version. Also, I think we should include the docs OpenAPI descriptions we use to limit these cases in the future.

@baywet
Copy link
Member

baywet commented Aug 8, 2023

alright, updated my PR to prepare for a patch version. It'll also contain python backing store support but I don't think that's and issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Go type:bug A broken experience WIP
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants