From aaffa8ee4acfb2179880140fbbe2cc8573440fc9 Mon Sep 17 00:00:00 2001 From: rkodev <43806892+rkodev@users.noreply.github.com> Date: Thu, 31 Oct 2024 15:49:36 +0300 Subject: [PATCH] refactor --- .../Writers/TypeScript/CodeFunctionWriter.cs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Kiota.Builder/Writers/TypeScript/CodeFunctionWriter.cs b/src/Kiota.Builder/Writers/TypeScript/CodeFunctionWriter.cs index f8e64ba0ca..cbb13932fa 100644 --- a/src/Kiota.Builder/Writers/TypeScript/CodeFunctionWriter.cs +++ b/src/Kiota.Builder/Writers/TypeScript/CodeFunctionWriter.cs @@ -95,12 +95,12 @@ private void WriteComposedTypeSerializer(CodeFunction codeElement, LanguageWrite { var paramName = composedParam.Name.ToFirstCharacterLowerCase(); writer.WriteLine($"if ({paramName} === undefined || {paramName} === null) return;"); - int pos = 0; + bool isFirst = true; foreach (var type in composedType.Types.Where(x => IsPrimitiveType(x, composedType, false))) { - var ifElse = pos == 0 ? "" : "else "; + var ifElse = isFirst ? "" : "else "; WriteCaseStatementForPrimitiveTypeSerialization(type, "undefined", paramName, codeElement, writer, ifElse); - pos++; + isFirst = false; } return; } @@ -433,10 +433,10 @@ private void WriteComposedTypeIfClause(CodeComposedTypeBase composedType, CodeFu var isCollectionOfEnum = IsCollectionOfEnum(codeProperty); var spreadOperator = isCollectionOfEnum ? "..." : string.Empty; - var pos = 0; + bool isFirst = true; foreach (var type in composedType.Types.Where(x => IsPrimitiveType(x, composedType))) { - var isElse = pos == 0 ? "" : "else "; + var isElse = isFirst ? "" : "else "; var nodeType = conventions.GetTypeString(type, method, false); var serializationName = GetSerializationMethodName(type, method.OriginalLocalMethod); if (string.IsNullOrEmpty(serializationName) || string.IsNullOrEmpty(nodeType)) return; @@ -447,7 +447,7 @@ private void WriteComposedTypeIfClause(CodeComposedTypeBase composedType, CodeFu writer.WriteLine($"writer.{serializationName}(\"{codeProperty.WireName}\", {spreadOperator}{modelParamName}.{codePropertyName}{defaultValueSuffix} as {nodeType});"); writer.CloseBlock(); - pos++; + isFirst = false; } }