- attempt at fixing failed idempotency uploads

Signed-off-by: Vincent Biret <[email protected]>

Author: baywet

.github/workflows/integration-tests.yml

@@ -197,10 +197,16 @@ jobs:
         shell: pwsh
         run: ./it/compare-generation.ps1 -descriptionUrl ${{ matrix.description }} -language ${{ matrix.language }}
         continue-on-error: ${{ steps.check-suppressed.outputs.IS_SUPPRESSED == 'true' }}
+      - id: replace_url
+        if: always()
+        run: |
+          ORIGINAL="${{ matrix.description }}"
+          REPLACED="${ORIGINAL//[-:<>|\*\?\\\/\.]/_}"
+          echo "ARTKEY=$REPLACED" >> $GITHUB_OUTPUT
       - uses: actions/upload-artifact@v3
-        if: failure()
+        if: always()
         with:
-          name: idempotency-artifacts
+          name: idempotency-${{ matrix.language }}-${{ steps.replace_url.outputs.ARTKEY }}
           path: idempotency-folder*.zip
 
   cleanup:

it/compare-generation.ps1

@@ -97,17 +97,19 @@ if ($HashString1 -eq $HashString2) {
 }
 else {
     Write-Error "The content of the folders is NOT identical"
+    $archivePath1 = Join-Path $rootPath -ChildPath "idempotency-folder1.zip"
+    $archivePath2 = Join-Path $rootPath -ChildPath "idempotency-folder2.zip"
 
-    if (Test-Path "idempotency-folder1.zip") {
-        Remove-Item "idempotency-folder1.zip" -Force
+    if (Test-Path $archivePath1) {
+        Remove-Item $archivePath1 -Force
     }
-    if (Test-Path "idempotency-folder2.zip") {
-        Remove-Item "idempotency-folder2.zip" -Force
+    if (Test-Path $archivePath2) {
+        Remove-Item $archivePath2 -Force
     }
 
     if ($dev -eq $false) {
-        Compress-Archive -Path $tmpFolder1 -DestinationPath "idempotency-folder1.zip"
-        Compress-Archive -Path $tmpFolder1 -DestinationPath "idempotency-folder2.zip"
+        Compress-Archive -Path $tmpFolder1 -DestinationPath $archivePath1
+        Compress-Archive -Path $tmpFolder1 -DestinationPath $archivePath2
         Exit 1
     }
 }