chore: applies review suggestions

baywet · web-flow · commit 2292e43b0c54 · 2024-11-13T10:07:12.000-05:00
diff --git a/src/Kiota.Builder/Writers/Php/PhpConventionService.cs b/src/Kiota.Builder/Writers/Php/PhpConventionService.cs
@@ -135,7 +135,7 @@ private string GetCollectionDocString(CodeParameter codeParameter)
         return codeParameter.Optional ? $"{doc}|null" : doc;
     }
 
-    internal static string RemoveInvalidDescriptionCharacters(string originalDescription) => originalDescription.Replace("\\", "/", StringComparison.OrdinalIgnoreCase).Replace("*/", "", StringComparison.OrdinalIgnoreCase);
+    internal static string RemoveInvalidDescriptionCharacters(string originalDescription) => originalDescription.Replace("\\", "/", StringComparison.OrdinalIgnoreCase).Replace("*/", string.Empty, StringComparison.OrdinalIgnoreCase);
     public override bool WriteShortDescription(IDocumentedElement element, LanguageWriter writer, string prefix = "", string suffix = "")
     {
         ArgumentNullException.ThrowIfNull(writer);

Original file line number	Diff line number	Diff line change
`@@ -135,7 +135,7 @@ private string GetCollectionDocString(CodeParameter codeParameter)`
`135`	`135`	`return codeParameter.Optional ? $"{doc}\|null" : doc;`
`136`	`136`	`}`
`137`	`137`
`138`		`- internal static string RemoveInvalidDescriptionCharacters(string originalDescription) => originalDescription.Replace("\\", "/", StringComparison.OrdinalIgnoreCase).Replace("*/", "", StringComparison.OrdinalIgnoreCase);`
	`138`	`+ internal static string RemoveInvalidDescriptionCharacters(string originalDescription) => originalDescription.Replace("\\", "/", StringComparison.OrdinalIgnoreCase).Replace("*/", string.Empty, StringComparison.OrdinalIgnoreCase);`
`139`	`139`	`public override bool WriteShortDescription(IDocumentedElement element, LanguageWriter writer, string prefix = "", string suffix = "")`
`140`	`140`	`{`
`141`	`141`	`ArgumentNullException.ThrowIfNull(writer);`