fix: excessive path escaping

Author: Andrew Omondi

CHANGELOG.md

@@ -24,6 +24,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - Fixed a bug where TypeScript would not properly build URIs with uppercase first characters query parameter names.[#5382](https://github.com/microsoft/kiota/issues/5382)
 - Fixed a bug where the description special characters are encoded. [5286](https://github.com/microsoft/kiota/issues/5286)
 - Fixed a bug where python constructor parameters are being cast to strings leading to bugs as the types is unknown on graph call. [microsoftgraph/msgraph-sdk-python#165](https://github.com/microsoftgraph/msgraph-sdk-python/issues/165)
+- Fixed a bug where child path segment from single parameter path segment would be incorrectly escaped. [#4814](https://github.com/microsoft/kiota/issues/4814)
 
 ## [1.18.0] - 2024-09-05
 

src/Kiota.Builder/KiotaBuilder.cs

@@ -634,7 +634,7 @@ private void CreateRequestBuilderClass(CodeNamespace currentNamespace, OpenApiUr
         {
             var propIdentifier = child.GetNavigationPropertyName(config.StructuredMimeTypes);
             var propType = child.GetNavigationPropertyName(config.StructuredMimeTypes, child.DoesNodeBelongToItemSubnamespace() ? ItemRequestBuilderSuffix : RequestBuilderSuffix);
-            if (child.Path.EndsWith(OpenApiUrlTreeNodeExtensions.ReservedItemName, StringComparison.OrdinalIgnoreCase))
+            if (child.Segment.Equals(OpenApiUrlTreeNodeExtensions.ReservedItemName, StringComparison.OrdinalIgnoreCase) && !child.DoesNodeBelongToItemSubnamespace())
                 propType = propType.Replace(OpenApiUrlTreeNodeExtensions.ReservedItemName, OpenApiUrlTreeNodeExtensions.ReservedItemNameEscaped, StringComparison.OrdinalIgnoreCase);
 
             if (child.IsPathSegmentWithSingleSimpleParameter())

tests/Kiota.Builder.Tests/KiotaBuilderTests.cs

@@ -256,6 +256,20 @@ await File.WriteAllTextAsync(tempFilePath, @$"openapi: 3.0.1
             application/json:
               schema:
                 $ref: '#/components/schemas/MediaResponseModel'
+  /media/item/{{id}}/nestedItem:
+    get:
+      parameters:
+        - name: id
+          in: path
+          required: true
+          schema:
+            type: string
+      responses:
+        '200':
+          content:
+            application/json:
+              schema:
+                $ref: '#/components/schemas/MediaResponseModel'
 components:
   schemas:
     MediaResponseModel:
@@ -308,6 +322,10 @@ await File.WriteAllTextAsync(tempFilePath, @$"openapi: 3.0.1
         var modelsNS = codeModel.FindNamespaceByName("ApiSdk.models");
         Assert.NotNull(modelsNS);
         Assert.NotNull(modelsNS.FindChildByName<CodeClass>("MediaResponseModel", false));
+        var nestedNestedItemProperty =
+            nestedItemRequestBuilder.FindChildByName<CodeProperty>("NestedItem", false);
+        Assert.NotNull(nestedNestedItemProperty);
+        Assert.Equal("NestedItemRequestBuilder", nestedNestedItemProperty.Type.Name, StringComparer.OrdinalIgnoreCase);
     }
     private readonly HttpClient _httpClient = new();
     [Fact]