Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fade component integration into Dialog #33306

Closed
1 of 5 tasks
pixel-perfectionist opened this issue Nov 20, 2024 · 0 comments · Fixed by #33288
Closed
1 of 5 tasks

Fade component integration into Dialog #33306

pixel-perfectionist opened this issue Nov 20, 2024 · 0 comments · Fixed by #33288
Assignees

Comments

@pixel-perfectionist
Copy link
Member

pixel-perfectionist commented Nov 20, 2024

Analyze existing Dialog and DialogBackdrop motion implementations for compatibility with Fade motion.
Modify the Dialog and DialogBackdrop components to include Fade motion using reusable motion atoms.

UPD: 11/18 Integration of the Fade component is closely linked with ongoing RFC reviews. The foundational work, including reusable motion atoms and updated API proposals, is complete and pending review. Once aligned with RFCs, the Fade component integration can proceed with minimal adjustments, as most of the code is already prepared in branches.

#33259
#33288

  • Fade motion is seamlessly integrated into both Dialog and DialogBackdrop components.
  • All animations perform as expected across supported browsers and devices.
  • Motion complies with Fluent UI guidelines, ensuring accessibility and design consistency.
  • Unit tests and integration tests validate the functionality of Fade motion within Dialog and DialogBackdrop.
  • Cross-browser testing is completed and any inconsistencies resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant