Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Button] Should loading spinner match size of icon? #3675

Open
2 of 6 tasks
riosn-n opened this issue Jul 9, 2024 · 2 comments
Open
2 of 6 tasks

[Button] Should loading spinner match size of icon? #3675

riosn-n opened this issue Jul 9, 2024 · 2 comments

Comments

@riosn-n
Copy link
Member

riosn-n commented Jul 9, 2024

Should the size of the spinner match the size of the icon? Otherwise, users will see a small shift in the layout as illustrated below:

https://snack.expo.dev/CQtJ1tMBQoQHFmV4Y3e3i?platform=android

Willing to submit a PR to fix?

  • I am willing to submit a PR to fix

Requested priority

High

Products/applications affected

Power Apps

Package version(s)

@fluentui-react-native/button": "0.37.3" (latest)

OS version(s)

No response

Platform

  • iOS
  • macOS
  • win32
  • windows
  • android

Xcode version

No response

Please provide a reproduction of the bug

https://snack.expo.dev/CQtJ1tMBQoQHFmV4Y3e3i?platform=android

Actual behavior

Layout shifts

Expected behavior

Layout doesn't shift

@Saadnajmi
Copy link
Collaborator

Good catch! Yeah we can probably match sizes to fix that

@Saadnajmi
Copy link
Collaborator

@Rios-N I should clarify. I agree this is a good fix, I'm not sure we have anyone on the Android side who can look at it anytime soon though. Is there any chance anyone in you or your team could look into it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants