Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add [multi-column sorting] to [FluentDataGrid] #3461

Open
StevenRasmussen opened this issue Mar 1, 2025 · 4 comments
Open

feat: add [multi-column sorting] to [FluentDataGrid] #3461

StevenRasmussen opened this issue Mar 1, 2025 · 4 comments
Labels
community:contribution Issue will/can be addressed by community contribution

Comments

@StevenRasmussen
Copy link
Contributor

🙋 Feature Request

It would be great if the FluentDataGrid component could support sorting by multiple columns similar to other grids. This would be initiated by holding the SHIFT key while clicking on a secondary/tertiary column.

@microsoft-github-policy-service microsoft-github-policy-service bot added the triage New issue. Needs to be looked at label Mar 1, 2025
@vnbaaij
Copy link
Collaborator

vnbaaij commented Mar 1, 2025

That would require some major, major work. The current grid has absolutely nothing in place to handle that. In fact, there is quite a bit of code that works under the assumption there is just one sort criterium set.
Sorry, but with the work we are doing on vNext, I don't see us spending time on this

@vnbaaij vnbaaij added closed:not-actionable There is no action to be taken in response to this issue. and removed triage New issue. Needs to be looked at labels Mar 1, 2025
@StevenRasmussen
Copy link
Contributor Author

@vnbaaij - Is this something you'd be willing to take a PR on? Would there be any conflicts with what you're working on for vNext?

@dvoituron
Copy link
Collaborator

Please note that components must be Accessible. Using only SHIFT for multi-selection is probably not enough. How do others make them accessible?

@vnbaaij
Copy link
Collaborator

vnbaaij commented Mar 1, 2025

@vnbaaij - Is this something you'd be willing to take a PR on? Would there be any conflicts with what you're working on for vNext?

Yes, of course we would take PR on it. I'm not expecting conflicts with v5. We made the change to use table rendering with v4. 11 alreasldy in preparation for that.

Just be advised that it will be a lot of work and, as Denis mentioned, it needs to be accessible as well.

If you're willing to take this on, it might make sense to break it up in a couple of smaller PR's. Also, for v5 we want all components to have unit tests. I think we can only take this in if this new part has tests then as well.

Hope you don't perceive this as a negative vibe from me. Just want to make sure you know what you will be getting into...

@vnbaaij vnbaaij added community:contribution Issue will/can be addressed by community contribution and removed closed:not-actionable There is no action to be taken in response to this issue. labels Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community:contribution Issue will/can be addressed by community contribution
Projects
None yet
Development

No branches or pull requests

3 participants