-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add [multi-column sorting] to [FluentDataGrid] #3461
Comments
That would require some major, major work. The current grid has absolutely nothing in place to handle that. In fact, there is quite a bit of code that works under the assumption there is just one sort criterium set. |
@vnbaaij - Is this something you'd be willing to take a PR on? Would there be any conflicts with what you're working on for vNext? |
Please note that components must be Accessible. Using only |
Yes, of course we would take PR on it. I'm not expecting conflicts with v5. We made the change to use table rendering with v4. 11 alreasldy in preparation for that. Just be advised that it will be a lot of work and, as Denis mentioned, it needs to be accessible as well. If you're willing to take this on, it might make sense to break it up in a couple of smaller PR's. Also, for v5 we want all components to have unit tests. I think we can only take this in if this new part has tests then as well. Hope you don't perceive this as a negative vibe from me. Just want to make sure you know what you will be getting into... |
🙋 Feature Request
It would be great if the
FluentDataGrid
component could support sorting by multiple columns similar to other grids. This would be initiated by holding theSHIFT
key while clicking on a secondary/tertiary column.The text was updated successfully, but these errors were encountered: